Update APT GPG Key and ensure apt::source is before package

[yakatz]

Pull Request (PR) description

apt update has been failing for a while because the old key expired and the repo is now signed with a new key.

It isn't possible to keep the key updated by downloading from the repository every time puppet runs - the only way to do that is to have the key in puppet itself so it can make sure it is up-to-date.

[yakatz]

This will have to be a major version bump

[kenyon]

You could get rid of the file resource for lldpd.asc here, and instead let apt::source handle it by passing a key hash with a content parameter.

[jay7x]

Some time ago I kinda "fixed" the same in puppet-caddy: https://github.com/voxpupuli/puppet-caddy/blob/91efe40e888e8f191611eaa3274c9dcdc35004b2/manifests/install/repo.pp#L23

[yakatz]

You could get rid of the file resource for lldpd.asc here, and instead let apt::source handle it by passing a key hash with a content parameter.

apt::key is deprecated in favor of shipping the key (using this approach or apt::keyring)

[kenyon]

You could get rid of the file resource for lldpd.asc here, and instead let apt::source handle it by passing a key hash with a content parameter.

apt::key is deprecated in favor of shipping the key (using this approach or apt::keyring)

I know, I'm suggesting this: https://github.com/puppetlabs/puppetlabs-apt/blob/5e34dcb822ae64c81e9aa8f10e048f4ddd59d525/manifests/source.pp#L207