Add basic SuSE support #194
Conversation
| @@ -89,6 +101,12 @@ | |||
| Optional[String] $sentry_dsn = undef, | |||
| Optional[Pattern[/.*:.+/]] $listen_address = undef, | |||
| Optional[Gitlab_ci_runner::Session_server] $session_server = undef, | |||
| Enum['repo', 'binary'] $install_method = 'repo', | |||
| Stdlib::HTTPUrl $binary_source = 'https://s3.dualstack.us-east-1.amazonaws.com/gitlab-runner-downloads/latest/binaries/gitlab-runner-linux-amd64', | |||
There was a problem hiding this comment.
| Stdlib::HTTPUrl $binary_source = 'https://s3.dualstack.us-east-1.amazonaws.com/gitlab-runner-downloads/latest/binaries/gitlab-runner-linux-amd64', | |
| Stdlib::HTTPSUrl $binary_source = 'https://s3.dualstack.us-east-1.amazonaws.com/gitlab-runner-downloads/latest/binaries/gitlab-runner-linux-amd64', |
There was a problem hiding this comment.
What about people with local http server without https? The idea is to let people override the url.
There was a problem hiding this comment.
Do we still need to support plaintext HTTP in 2024? :(
There was a problem hiding this comment.
Yes. Customer insists on using an internal HTTP only server. :-(
| @@ -7,6 +7,11 @@ | |||
| ) { | |||
| assert_private() | |||
|
|
|||
| if $facts['os']['family'] == 'Suse' { | |||
There was a problem hiding this comment.
Is it Suse for suse opensoure and enterprise? does the code work on both systems?
There was a problem hiding this comment.
Both. Or even better: this method works for any OS! I am about to implement the any OS usage in a next PR
| @@ -7,6 +7,11 @@ | |||
| ) { | |||
| assert_private() | |||
|
|
|||
| if $facts['os']['family'] == 'Suse' { | |||
| exec { "${gitlab_ci_runner::binary_path} install -u ${gitlab_ci_runner::user}": | |||
There was a problem hiding this comment.
do we need to notify the exec when there's an update for the runner? Do we need to run systemctl daemon-reload before the service resource?
There was a problem hiding this comment.
No. My test installation did not require a separate systemctl daemon-reload
No description provided.