Support for sensitive environment variables

[teluq-pbrideau]

Pull Request (PR) description

The environment option does not support sensitive value. I would like to put http_proxy=http://user:[email protected]:3128 in an environment variable, but the content is displayed in cleartext in the log.

This PR allow to define an environment content as sensitive as followed:

cron::job { 'example' :
  environment => [
    Sensitive('http_proxy=http://user:[email protected]:3128'),
    'PATH=/usr/bin',
  ],
  command     => 'sleep 10',
}

same for cron::job::multiple

There was validation in the erb template about the environment variables, and funky .join(\n).split(\n) but I think it is no longer necessary. The content is validated by puppet directly on the call to cron::job. Is this behavior a remnant of old puppet when there was no types?

I also removed the environment variable in the cron::job::multiple::jobs array, as it was not defined in the old erb, and kept the same behavior for the epp.

Feel free to raise concern if you think my assumptions were wrong

This Pull Request (PR) fixes the following issues

[teluq-pbrideau]

@bastelfreak Would it be something wanted if I work further on this PR? Or should I abandon this completely? I don’t want to work on something that will be discarded…

[bastelfreak]

@teluq-pbrideau hi! Sorry this PR got a bit lost under the radar. I think it's still very useful. Could you rebase it against our latest HEAD branch? And you can always ping us on slack or IRC and then we can take a look at the PR. We've #voxpupuli on the Libera IRC network and also #voxpupuli on https://slack.puppet.com/

[bastelfreak]

thanks a lot for updating it! I will do a minor release in #140 and afterward merge your PR.