Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release 5.1.2 #105

Merged
merged 1 commit into from
Aug 22, 2024
Merged

Conversation

vchepkov
Copy link
Contributor

Release 5.1.2

Copy link
Member

@kenyon kenyon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The -rc0 needs to be removed from the version in metadata.json for the changelog to be generated correctly.

I wonder why that simp-2.3.1 tag appeared. Maybe should be deleted?

@vchepkov
Copy link
Contributor Author

vchepkov commented Aug 21, 2024

Hmm, I used documentation https://voxpupuli.org/docs/releasing_version/

CHANGELOG_GITHUB_TOKEN='mytoken' bundle exec rake release:prepare

I assumed that will be removed during actual release, I will remove the suffix

@vchepkov
Copy link
Contributor Author

I don't see that tag?

$ git tag
2.0.0
2.0.1
2.1.0
2.2.0
2.3.0
2.4.0
3.0.0
3.0.1
3.1.0
3.2.0
v4.0.0
v5.0.0
v5.0.1
v5.1.0
v5.1.1

Copy link
Member

@kenyon kenyon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That tag is here: https://github.com/voxpupuli/puppet-augeasproviders_grub/releases/tag/simp-2.3.1

🤷

I think you need to regenerate the changelog now that you've set the version. It shouldn't say Unreleased, it should be v5.1.2. Here's an example: voxpupuli/puppet-python#697

@vchepkov
Copy link
Contributor Author

I just committed my section of the change and removed others manually

@vchepkov vchepkov requested a review from kenyon August 22, 2024 00:05
@kenyon
Copy link
Member

kenyon commented Aug 22, 2024

I deleted that simp-2.3.1 tag from the repo so that hopefully it doesn't show up in the next changelog.

@bastelfreak bastelfreak merged commit 95370a1 into voxpupuli:master Aug 22, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants