Use tmpfile extension #3
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ekohl
force-pushed
the
use-tmpfile-extension
branch
from
a8f7869 to
eecc0fb
Compare
bastelfreak
approved these changes
Oct 16, 2023
ekohl
force-pushed
the
use-tmpfile-extension
branch
from
eecc0fb to
7b8a06a
Compare
bastelfreak
approved these changes
Jan 8, 2024
ekohl
force-pushed
the
use-tmpfile-extension
branch
from
1769cf9 to
6604e02
Compare
bastelfreak
approved these changes
May 6, 2024
|
I think it fails because it's mocked here: However, the method signature isn't correct so the mock fails. At runtime it'd probably work. Opened voxpupuli/beaker#1863 to fix it. |
bastelfreak
reviewed
May 6, 2024
beaker_puppet_helpers.gemspec
Outdated
| @@ -16,6 +16,6 @@ Gem::Specification.new do |s| | |||
| s.require_paths = ['lib'] | |||
|
|
|||
| # Run time dependencies | |||
| s.add_runtime_dependency 'beaker', '>= 4', '< 6' | |||
| s.add_runtime_dependency 'beaker', '~> 5.2' | |||
There was a problem hiding this comment.
Suggested change
| s.add_runtime_dependency 'beaker', '~> 5.2' | |
| s.add_runtime_dependency 'beaker', '~> 5.8', '>= 5.8.1' |
Having a proper extension, even for temporary files is much cleaner.
ekohl
force-pushed
the
use-tmpfile-extension
branch
from
6604e02 to
bd005ac
Compare
smortex
approved these changes
May 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Having a proper extension, even for temporary files is much cleaner.
Depends on voxpupuli/beaker#1735