test: switch back to babel-based coverage

c8/v8 coverage is buggy post v20.9.0: nodejs/node#51251

.node-version

@@ -1 +1 @@
-20.14.0
+20.16.0

apps/admin/backend/jest.config.js

@@ -16,13 +16,13 @@ module.exports = {
   ],
   coverageThreshold: {
     global: {
-      statements: 100,
-      branches: 100,
-      functions: 100,
-      lines: 100,
+      statements: 99,
+      branches: 98,
+      lines: 99,
+      functions: 98,
     },
   },
-  coverageProvider: 'v8',
+  coverageProvider: 'babel',
   collectCoverageFrom: [
     '**/*.{ts,tsx}',
     '!**/*.d.ts',

apps/admin/backend/src/adjudication.ts

@@ -29,7 +29,7 @@ export function adjudicateVote(
 
   const scannedIsVote = contestVotes
     ? contestVotes.includes(voteAdjudication.optionId)
-    : /* c8 ignore next 1 */
+    : /* istanbul ignore next */
       false;
 
   // if the vote is already the target status, do nothing
@@ -63,10 +63,9 @@ async function logWriteInAdjudication({
         return `a vote for an official candidate (${initialWriteInRecord.candidateId})`;
       case 'write-in-candidate':
         return `a vote for a write-in candidate (${initialWriteInRecord.candidateId})`;
-      /* c8 ignore start */
+      /* istanbul ignore next */
       default:
         throwIllegalValue(initialWriteInRecord, 'adjudicationType');
-      /* c8 ignore stop */
     }
   })();
 
@@ -80,10 +79,9 @@ async function logWriteInAdjudication({
         return `a vote for a write-in candidate (${adjudicationAction.candidateId})`;
       case 'reset':
         return `unadjudicated`;
-      /* c8 ignore start */
+      /* istanbul ignore next */
       default:
         throwIllegalValue(adjudicationAction, 'type');
-      /* c8 ignore stop */
     }
   })();
 
@@ -169,10 +167,9 @@ export async function adjudicateWriteIn(
       // ensure the vote appears as it originally was in tallies
       store.deleteVoteAdjudication(initialWriteInRecord);
       break;
-    /* c8 ignore start */
+    /* istanbul ignore next */
     default:
       throwIllegalValue(adjudicationAction, 'type');
-    /* c8 ignore stop */
   }
 
   // if we are switching away from a write-in candidate, we may have to clean

apps/admin/backend/src/app.ts

@@ -138,7 +138,7 @@ function getCurrentElectionRecord(
   workspace: Workspace
 ): Optional<ElectionRecord> {
   const electionId = workspace.store.getCurrentElectionId();
-  /* c8 ignore next 3 */
+  /* istanbul ignore next */
   if (!electionId) {
     return undefined;
   }
@@ -244,7 +244,7 @@ function buildApi({
       return printer.status();
     },
 
-    /* c8 ignore start */
+    /* istanbul ignore next */
     generateLiveCheckQrCodeValue() {
       const { machineId } = getMachineConfig();
       const electionRecord = getCurrentElectionRecord(workspace);
@@ -253,7 +253,6 @@ function buildApi({
         ballotHash: electionRecord?.electionDefinition?.ballotHash,
       });
     },
-    /* c8 ignore stop */
 
     async getUsbDriveStatus(): Promise<UsbDriveStatus> {
       return usbDrive.status();
@@ -322,12 +321,11 @@ function buildApi({
           signatureFile.fileName,
           signatureFile.fileContents
         );
-        /* c8 ignore start: Tricky to make this second export err but the first export succeed
+        /* istanbul ignore next: Tricky to make this second export err but the first export succeed
           without significant mocking */
         if (exportSignatureFileResult.isErr()) {
           return exportSignatureFileResult;
         }
-        /* c8 ignore stop */
       } finally {
         await fs.rm(tempDirectory, { recursive: true });
       }

apps/admin/backend/src/cast_vote_records.ts

@@ -138,16 +138,14 @@ export async function listCastVoteRecordExportsOnUsbDrive(
         case 'not-directory': {
           return err('found-file-instead-of-directory');
         }
-        /* c8 ignore start: Hard to trigger without significant mocking */
+        /* istanbul ignore next: Hard to trigger without significant mocking */
         case 'permission-denied': {
           return err('permission-denied');
         }
-        /* c8 ignore stop */
-        /* c8 ignore start: Compile-time check for completeness */
+        /* istanbul ignore next: Compile-time check for completeness */
         default: {
           throwIllegalValue(errorType);
         }
-        /* c8 ignore stop */
       }
     }
 

apps/admin/backend/src/exports/csv_ballot_count_report.ts

@@ -68,7 +68,7 @@ function buildRow({
   const values: string[] = [...metadataValues];
 
   const counts: number[] = [];
-  /* c8 ignore next - trivial fallthrough case */
+  /* istanbul ignore next - trivial fallthrough case */
   const manual = cardCounts.manual ?? 0;
   const { bmd } = cardCounts;
   const total = getBallotCount(cardCounts);
@@ -81,7 +81,7 @@ function buildRow({
 
   if (maxSheetsPerBallot) {
     for (let i = 0; i < maxSheetsPerBallot; i += 1) {
-      /* c8 ignore next - trivial fallthrough case */
+      /* istanbul ignore next - trivial fallthrough case */
       const currentSheetCount = cardCounts.hmpb[i] ?? 0;
       counts.push(currentSheetCount);
     }

apps/admin/backend/src/reports/readiness.ts

@@ -32,9 +32,8 @@ async function getReadinessReport({
     : undefined;
 
   return AdminReadinessReport({
-    /* c8 ignore start */
+    /* istanbul ignore next */
     batteryInfo: (await getBatteryInfo()) ?? undefined,
-    /* c8 ignore stop */
     diskSpaceSummary: await workspace.getDiskSpaceSummary(),
     printerStatus: await printer.status(),
     mostRecentPrinterDiagnostic:

apps/admin/backend/src/reports/titles.ts

@@ -148,7 +148,7 @@ export function generateTitleForReport({
           return ok(`Undervoted ${reportType} Report`);
         case 'hasWriteIn':
           return ok(`Write-In ${reportType} Report`);
-        /* c8 ignore next 2 */
+        /* istanbul ignore next */
         default:
           throwIllegalValue(adjudicationFlag);
       }

apps/admin/backend/src/server.ts

@@ -49,7 +49,7 @@ export async function start({
   debug('starting server...');
   detectDevices({ logger: baseLogger });
   let resolvedWorkspace = workspace;
-  /* c8 ignore start */
+  /* istanbul ignore next */
   if (!resolvedWorkspace) {
     const workspacePath = ADMIN_WORKSPACE;
     if (!workspacePath) {
@@ -68,11 +68,10 @@ export async function start({
     }
     resolvedWorkspace = createWorkspace(workspacePath);
   }
-  /* c8 ignore stop */
 
   let resolvedApp = app;
 
-  /* c8 ignore start */
+  /* istanbul ignore next */
   if (!resolvedApp) {
     const auth = new DippedSmartCardAuth({
       card:
@@ -101,7 +100,6 @@ export async function start({
       workspace: resolvedWorkspace,
     });
   }
-  /* c8 ignore stop */
 
   const server = resolvedApp.listen(port, async () => {
     await baseLogger.log(LogEventId.ApplicationStartup, 'system', {

apps/admin/backend/src/store.ts

@@ -1353,7 +1353,7 @@ export class Store {
 
     for (const adjudication of adjudications) {
       const currentContestVotes =
-        votes[adjudication.contestId] ?? /* c8 ignore next 1 */ [];
+        votes[adjudication.contestId] ?? /* istanbul ignore next */ [];
       if (adjudication.isVote) {
         votes[adjudication.contestId] = [
           ...currentContestVotes,
@@ -1521,7 +1521,7 @@ export class Store {
         ballotStyleId: groupBy.groupByBallotStyle
           ? row.ballotStyleId
           : undefined,
-        /* c8 ignore next - edge case coverage needed for bad party grouping in general election */
+        /* istanbul ignore next - edge case coverage needed for bad party grouping in general election */
         partyId: groupBy.groupByParty ? row.partyId ?? undefined : undefined,
         batchId: groupBy.groupByBatch ? row.batchId : undefined,
         scannerId: groupBy.groupByScanner ? row.scannerId : undefined,
@@ -1880,7 +1880,7 @@ export class Store {
         ballotStyleId: groupBy.groupByBallotStyle
           ? row.ballotStyleId
           : undefined,
-        /* c8 ignore next - edge case coverage needed for bad party grouping in general election */
+        /* istanbul ignore next - edge case coverage needed for bad party grouping in general election */
         partyId: groupBy.groupByParty ? row.partyId ?? undefined : undefined,
         batchId: groupBy.groupByBatch ? row.batchId : undefined,
         scannerId: groupBy.groupByScanner ? row.scannerId : undefined,
@@ -2547,7 +2547,7 @@ export class Store {
     updateMaximumUsableDiskSpace(this.client, space);
   }
 
-  /* c8 ignore start */
+  /* istanbul ignore next */
   getDebugSummary(): Map<string, number> {
     const tableNameRows = this.client.all(
       `select name from sqlite_schema where type='table' order by name;`
@@ -2567,5 +2567,4 @@ export class Store {
       )
     );
   }
-  /* c8 ignore stop */
 }

apps/admin/backend/src/tabulation/card_counts.ts

@@ -33,7 +33,7 @@ function addCardTallyToCardCounts({
   } else {
     // eslint-disable-next-line no-param-reassign
     cardCounts.hmpb[card.sheetNumber - 1] =
-      /* c8 ignore next - trivial fallback case */
+      /* istanbul ignore next - trivial fallback case */
       (cardCounts.hmpb[card.sheetNumber - 1] ?? 0) + tally;
   }
 

apps/admin/backend/src/tabulation/full_results.ts

@@ -180,7 +180,7 @@ export async function tabulateElectionResults({
           });
         }
       );
-      /* c8 ignore next 3 - debug only */
+      /* istanbul ignore next - debug only */
     } else {
       debug('filter or group by is not compatible with manual results');
     }

apps/admin/backend/src/tabulation/write_ins.ts

@@ -146,7 +146,7 @@ function addWriteInTallyToElectionWriteInSummary({
           isWriteIn: true,
         };
         break;
-      /* c8 ignore next 2 */
+      /* istanbul ignore next */
       default:
         throwIllegalValue(writeInTally);
     }

apps/admin/backend/src/util/auth.ts

@@ -29,7 +29,7 @@ export function constructAuthMachineState(
     return record;
   })();
 
-  /* c8 ignore next 3 - covered by integration testing */
+  /* istanbul ignore next - covered by integration testing */
   const jurisdiction = isIntegrationTest()
     ? TEST_JURISDICTION
     : process.env.VX_MACHINE_JURISDICTION ?? DEV_JURISDICTION;
@@ -64,6 +64,6 @@ export async function getUserRole(
   if (authStatus.status === 'logged_in') {
     return authStatus.user.role;
   }
-  /* c8 ignore next 2 - trivial fallback case */
+  /* istanbul ignore next - trivial fallback case */
   return 'unknown';
 }

apps/admin/backend/src/util/cdf_results.ts

@@ -59,7 +59,7 @@ function buildOfficialCandidates(
   return candidates.map((candidate) => ({
     '@type': 'ElectionResults.Candidate',
     '@id': candidate.id,
-    /* c8 ignore next 1 -- trivial fallthrough case */
+    /* istanbul ignore next -- trivial fallthrough case */
     PartyId: candidate.partyIds?.[0],
     BallotName: asInternationalizedText(candidate.name),
   }));

apps/admin/backend/src/util/export_file.ts

@@ -21,7 +21,7 @@ export function exportFile({
   const exporter = new Exporter({
     allowedExportPatterns: ADMIN_ALLOWED_EXPORT_PATTERNS,
     /* We're not using `exportDataToUsbDrive` here, so a mock `usbDrive` is OK */
-    /* c8 ignore start */
+    /* istanbul ignore next */
     usbDrive: {
       status: () =>
         Promise.resolve({
@@ -30,7 +30,6 @@ export function exportFile({
       eject: () => Promise.resolve(),
       format: () => Promise.resolve(),
     },
-    /* c8 ignore stop */
   });
 
   debug('exporting data to file %s', path);

apps/admin/backend/src/util/write_ins.ts

@@ -40,7 +40,7 @@ export async function getWriteInImageView({
   const contestLayout = layout.contests.find(
     (contest) => contest.contestId === contestId
   );
-  /* c8 ignore next 3 - TODO: revisit our layout assumptions based on our new ballots */
+  /* istanbul ignore next - TODO: revisit our layout assumptions based on our new ballots */
   if (!contestLayout) {
     throw new Error('unable to find a layout for the specified contest');
   }
@@ -52,13 +52,13 @@ export async function getWriteInImageView({
   const writeInOptionIndex = safeParseNumber(
     optionId.slice('write-in-'.length)
   );
-  /* c8 ignore next 3 - TODO: revisit our layout assumptions based on our new ballots */
+  /* istanbul ignore next - TODO: revisit our layout assumptions based on our new ballots */
   if (writeInOptionIndex.isErr() || writeInOptions === undefined) {
     throw new Error('unable to interpret layout write-in options');
   }
 
   const writeInLayout = writeInOptions[writeInOptionIndex.ok()];
-  /* c8 ignore next 3 - TODO: revisit our layout assumptions based on our new ballots */
+  /* istanbul ignore next - TODO: revisit our layout assumptions based on our new ballots */
   if (writeInLayout === undefined) {
     throw new Error('unexpected write-in option index');
   }

apps/admin/backend/src/util/zip.ts

@@ -11,7 +11,7 @@ export function addFileToZipStream(
 ): Promise<void> {
   return new Promise<void>((resolve, reject) => {
     zipStream.entry(file.contents, { name: file.path }, (error) => {
-      /* c8 ignore next 2 - trivial error case */
+      /* istanbul ignore next - trivial error case */
       if (error) {
         reject(error);
       } else {

apps/central-scan/backend/jest.config.js

@@ -12,7 +12,7 @@ module.exports = {
   roots: ['<rootDir>/src'],
   setupFiles: ['<rootDir>/test/set_env_vars.ts'],
   setupFilesAfterEnv: ['<rootDir>/test/setup_custom_matchers.ts'],
-  coverageProvider: 'v8',
+  coverageProvider: 'babel',
   collectCoverageFrom: [
     '**/*.{ts,tsx}',
     '!**/node_modules/**',
@@ -23,10 +23,10 @@ module.exports = {
   ],
   coverageThreshold: {
     global: {
-      statements: 94,
-      branches: 86,
+      statements: 91,
+      branches: 77,
       functions: 91,
-      lines: 94,
+      lines: 91,
     },
   },
 };

apps/central-scan/backend/src/readiness_report.ts

@@ -31,9 +31,8 @@ export async function saveReadinessReport({
   const generatedAtTime = new Date(getCurrentTime());
   const electionDefinition = store.getElectionDefinition();
   const report = CentralScanReadinessReport({
-    /* c8 ignore start */
+    /* istanbul ignore next */
     batteryInfo: (await getBatteryInfo()) ?? undefined,
-    /* c8 ignore stop */
     diskSpaceSummary: await workspace.getDiskSpaceSummary(),
     isScannerAttached,
     mostRecentScannerDiagnostic: