This repository has been archived by the owner on Nov 3, 2020. It is now read-only.
shallow copies are evil. Copy the DOM node properly. #126
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
benadida
force-pushed
the
fix-last-blank-page-qr-code
branch
from
092ee0d
to
23cfeed
Compare
eventualbuddha
approved these changes
Sep 3, 2020
Comment on lines
+150
to
+154
| newLastPageElement.setAttribute( | ||
| 'data-page-number', | ||
| `${pages.length + 1}` | ||
| ) | ||
| newLastPageElement.setAttribute('data-id', `page-${pages.length + 1}`) |
There was a problem hiding this comment.
Is there a reason not to use the approach we had, i.e.
Suggested change
| newLastPageElement.setAttribute( | |
| 'data-page-number', | |
| `${pages.length + 1}` | |
| ) | |
| newLastPageElement.setAttribute('data-id', `page-${pages.length + 1}`) | |
| newLastPageElement.dataset.pageNumber = `${pages.length + 1}` | |
| newLastPageElement.dataset.id = `page-${pages.length + 1}` |
There was a problem hiding this comment.
maybe, but the approach we had was via setAttribute so I didn't want to change it. I added the id one cause it was missing.
Comment on lines
+164
to
+167
| const newPage = { | ||
| ...pages[pages.length - 1], | ||
| element: newLastPageElement, | ||
| } |
There was a problem hiding this comment.
This is the actual fix, right? Everything else should be equivalent.
There was a problem hiding this comment.
should, yes. Trying to change as little as possible.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
addresses #114.