Add button to audit admin UI for downloading reported results summed by jurisdiction as CSV #1894
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arsalansufi
commented
Mar 4, 2024
| contest_choice_csv_headers = construct_contest_choice_csv_headers(election) | ||
| csv_headers = [ | ||
| "Jurisdiction", | ||
| *contest_choice_csv_headers.values(), |
There was a problem hiding this comment.
Same note here as in #1893 (comment) re dictionaries being ordered
arsalansufi
commented
Mar 4, 2024
| icon="download" | ||
| href={`/api/election/${electionId}/batch-tallies/summed-by-jurisdiction-csv`} | ||
| > | ||
| Download Reported Results |
There was a problem hiding this comment.
Landed on the term "Reported Results" since that's what we call these results in the final audit report
jonahkagan
approved these changes
Mar 4, 2024
server/api/batch_tallies.py
Outdated
| @api.route( | ||
| "/election/<election_id>/batch-tallies/summed-by-jurisdiction-csv", methods=["GET"], | ||
| ) | ||
| @restrict_access([UserType.AUDIT_ADMIN, UserType.JURISDICTION_ADMIN]) |
There was a problem hiding this comment.
Can jurisdiction admins download this file? I don't think so. So I think it makes sense to remove their access
There was a problem hiding this comment.
Good catch! Copy-paste error: 931dad6
| icon="download" | ||
| href={`/api/election/${electionId}/batch-tallies/summed-by-jurisdiction-csv`} | ||
| > | ||
| Download Reported Results |
arsalansufi
force-pushed
the
arsalan/download-reported-results
branch
from
816f360 to
931dad6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Issue link: #1867
During previous batch audits, our audit specialists have manually downloaded every jurisdiction's candidate-totals-by-batch file, summed the numbers across batches, and prepared a summary file to compare against state-published results. A very cumbersome task 😅.
This PR builds the generation of this summary file into the product.
Before audit launch
After audit launch
Sample CSV before all jurisdiction files have been uploaded
Sample CSV after all jurisdiction files have been uploaded
Some entries are still blank because Contest 2 only exists in Jurisdiction 1.
For single-contest batch audits, the headers don't include contest names.
Testing