Update for using Handlers (by @WBerredo) and support for routing annotations (basic) #38
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
WickedSilver
commented
Apr 1, 2016
•
WickedSilver
commented
- Merged Work with handlers as service #12 (by @WBerredo) and solved conflicts,
- Fixed bugs from merge,
- Implemented --format parameter to command for support of routing annotation.
- Implemented test generation option
- Added support for yml service generation
This reverts commit 5a13dd3. Only a commit test
…cking and creating the folder if it doesn't exist
… to rest handler methods
|
Currently working on generation of tests, after that's complete i will reopen de pull request. |
# Implemented - automatic test generation - handling of entity constraints for tests - added yml support for service definition # Details * fixed typo * added creation of test base case * did this cause hard error? * fix for twig syntax error * fix for formatting of the included tests * fixed double if in oauth/setup.php.twig * object fields should not be put after eachother but under eachother * object fields should not be put after eachother but under eachother * added templates for no-authentication test * added friendly test mode function * added friendly test mode function * added friendly test mode function * added friendly test mode function * fixed typos in test cases * setup.php.twig format fixes * setup.php.twig format fixes * mode oauth base case command independent * added returning response content on error in tests * fixed defaults in interactive mode * removed non-working interactive mode for oauth username/password * fixed problems in oauth2 base testcase * fix for tests of oauth * added alpha version of ManyToOne support * added support for array and date internval types in testing * fixed typo in oauth setup for loop * added test version of service generation as YML format * added test version of service generation as YML format * fixed handlers so Entities in sub maps is supported * fixed handlers so Entities in sub maps is supported * fixed handlers so Entities in sub maps is supported * changed BaseTest location to be always in the root of Base * made tests independant of entity being in sub-map (AppBundle:User/User) * added usage of parameters in services.yml * made controller compatible with sub-entity (AppBundle:User\User) * fixed type in generation of serviceREST.yml file * fixed twig replace for controller actions * now using YmlLoader for loading yml instead of the XmlLoader * removed unused testing code and now adding services/params to service yml file instead of replacing them * added support of ManyToOne and OneToMany fields in oauth test case * added forgotten line closing ';' * made assoc field suffix with underscore for clarity * added a parameter overview to the readmes and fixed some layout issues in the setup for oauth test * added comments to setup * re-formatted the setup for testing and made it for both oauth and no-authentication * testing with Entity constraints, let's check the content * testing with Entity constraints, let's check the content * testing with Entity constraints, let's check the content * testing with Entity constraints, let's check the content * made bundle symfony dependant (added symfony to composer) and added testing version of checking constraints for fields in the test * made bundle symfony dependant (added symfony to composer) and added testing version of checking constraints for fields in the test * added constraint handling in setup template * added support for length constraint
…erator, real code change for this merge is done in the previous commit
|
Added generation of tests, mostly for oauth2 only at the moment but extendible for any format. Any feedback is welcome :) |
|
@WickedSilver I started to look at this and it looks very good. One issue I came across is the routing doesn't seem to work when I select annotations. It works fine with YML. |
|
@davidwdan Thanks for looking at my pull request and for the positive feedback 😄 app:
resource: "@AppBundle/Controller/"
type: annotationCan you confirm this? |
* fixed typo * added creation of test base case * did this cause hard error? * fix for twig syntax error * fix for formatting of the included tests * fixed double if in oauth/setup.php.twig * object fields should not be put after eachother but under eachother * object fields should not be put after eachother but under eachother * added templates for no-authentication test * added friendly test mode function * added friendly test mode function * added friendly test mode function * added friendly test mode function * fixed typos in test cases * setup.php.twig format fixes * setup.php.twig format fixes * mode oauth base case command independent * added returning response content on error in tests * fixed defaults in interactive mode * removed non-working interactive mode for oauth username/password * fixed problems in oauth2 base testcase * fix for tests of oauth * added alpha version of ManyToOne support * added support for array and date internval types in testing * fixed typo in oauth setup for loop * added test version of service generation as YML format * added test version of service generation as YML format * fixed handlers so Entities in sub maps is supported * fixed handlers so Entities in sub maps is supported * fixed handlers so Entities in sub maps is supported * changed BaseTest location to be always in the root of Base * made tests independant of entity being in sub-map (AppBundle:User/User) * added usage of parameters in services.yml * made controller compatible with sub-entity (AppBundle:User\User) * fixed type in generation of serviceREST.yml file * fixed twig replace for controller actions * now using YmlLoader for loading yml instead of the XmlLoader * removed unused testing code and now adding services/params to service yml file instead of replacing them * added support of ManyToOne and OneToMany fields in oauth test case * added forgotten line closing ';' * made assoc field suffix with underscore for clarity * added a parameter overview to the readmes and fixed some layout issues in the setup for oauth test * added comments to setup * re-formatted the setup for testing and made it for both oauth and no-authentication * testing with Entity constraints, let's check the content * testing with Entity constraints, let's check the content * testing with Entity constraints, let's check the content * testing with Entity constraints, let's check the content * made bundle symfony dependant (added symfony to composer) and added testing version of checking constraints for fields in the test * made bundle symfony dependant (added symfony to composer) and added testing version of checking constraints for fields in the test * added constraint handling in setup template * added support for length constraint * and fixed a forgotten merge conflict * now creating the YAML reference for use of annotation routing if it doesn't already exist. * now creating the YAML reference for use of annotation routing if it doesn't already exist. * now creating the YAML reference for use of annotation routing if it doesn't already exist. * now creating the YAML reference for use of annotation routing if it doesn't already exist.
|
The issue with annotation routing should be fixed in the previous commit. |
* fixed routing issues for generation of sub-entities
Explain resource parameter
Update README.md
Fix to support Symfony >=2.8
Updated Dependencies to support FosRest 2.x
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.