-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added more error handling #7
base: master
Are you sure you want to change the base?
Conversation
Hi @nepda , I made some changes after the PR from early and added some automated testing as well. Is there any way that you can rebase these changes on the current release (0.1.1)? |
You've changed the error handling from returning the error to the poster, to an "internal" exception. Can you explain why this is the better approach? |
Conflicts: src/WampPost/WampPost.php
I will fix the broken tests as soon as the error handling question is clarified ;) |
In the test:
With Thruway, you have to throw an exception to send an error back from the Callee side. Throwing the WampErrorException gives that end control over exactly what gets put into the error message. |
A few more messages