Freya tf tree #95
Freya tf tree #95
Conversation
asv_setup/CMakeLists.txt
Outdated
| @@ -23,4 +23,10 @@ if(BUILD_TESTING) | |||
| ament_lint_auto_find_test_dependencies() | |||
| endif() | |||
There was a problem hiding this comment.
line 4-24 is unnecessary for this package and should be removed.
There was a problem hiding this comment.
Colcon won't build the package without them though?
Unknown CMake command "ament_package"
There was a problem hiding this comment.
ah, ok. then just leave it as is
There was a problem hiding this comment.
Also, can we rename "tf.launch.yaml" to "tf_launch.yaml"?
I think pc.launch.yaml should be deleted as well.
There was a problem hiding this comment.
pc.launch.yaml will be taken care of when merging.
There was a problem hiding this comment.
The if(BUILD_TESTING) can be removed.
The convention is to have .launch.yaml so just leaving it as is is fine :)
There was a problem hiding this comment.
Also remove the comment
-# uncomment the following section in order to fill in
-# further dependencies manually.
-# find_package( REQUIRED)
Implemented Freya TF tree in YAML with updated measurements from mechanical.