fixed stuff

vortexntnu · Nov 12, 2023 · b1620a4 · b1620a4
1 parent 4c0aecc
commit b1620a4
Show file tree

Hide file tree

Showing 6 changed files with 11 additions and 10 deletions.
diff --git a/sensors/bms/bms/freya_bms.py b/sensors/bms/bms/freya_bms.py
@@ -1,8 +1,6 @@
 import subprocess
 import rclpy.logging
 
-#TODO: use ros2 logging instead of python print
-
 class BMS:
     """ Class containing Freya's BMS system. 
 

diff --git a/sensors/bms/bms/freya_bms_node.py → sensors/bms/bms/freya_bms_publisher_node.py b/sensors/bms/bms/freya_bms_node.py → sensors/bms/bms/freya_bms_publisher_node.py
diff --git a/sensors/bms/launch/bms_launch.py b/sensors/bms/launch/bms_launch.py
@@ -5,6 +5,6 @@ def generate_launch_description():
     return LaunchDescription([
         Node(
             package='bms',
-            executable='bms_publisher'
+            executable='freya_bms_publisher_node'
         )
     ])
diff --git a/sensors/bms/package.xml b/sensors/bms/package.xml
@@ -2,10 +2,10 @@
 <?xml-model href="http://download.ros.org/schema/package_format3.xsd" schematypens="http://www.w3.org/2001/XMLSchema"?>
 <package format="3">
   <name>bms</name>
-  <version>0.0.0</version>
-  <description>TODO: Package description</description>
-  <maintainer email="karate.martynas1@gmail.com">vortex</maintainer>
-  <license>TODO: License declaration</license>
+  <version>1.0.0</version>
+  <description>Logs information about Freya's battery packs</description>
+  <maintainer email="dpersson16@gmail.com">vortex</maintainer>
+  <license>TODO</license>
 
   <test_depend>ament_copyright</test_depend>
   <test_depend>ament_flake8</test_depend>

diff --git a/sensors/bms/readme.md b/sensors/bms/readme.md
@@ -4,7 +4,7 @@
 
 This package contains a script for collecting BMS 
 data, as well as a ROS node for publishing that 
-data.
+data. The system is documented at [wiki page](https://vortex.a2hosted.com/index.php/Freya_BMS).
 
 ## ROS2
 
@@ -84,7 +84,10 @@ create_key_value_pair(key: str, value) -> KeyValue:
 
 ## Startup service
 
-This package also contains a .service script for running the node on startup. To enable this, just run (from this directory)
+Note: The .service file may need to be edited in order to source the setup.bash file 
+from the correct workspace.
+
+This package also contains a .service file for running the node on startup. To enable this, just run (from this directory)
 ```
 sudo cp startup_script/bms_startup.service /etc/systemd/system/bms_startup.service
 ```

diff --git a/sensors/bms/setup.py b/sensors/bms/setup.py
@@ -23,7 +23,7 @@
     tests_require=['pytest'],
     entry_points={
         'console_scripts': [
-            'bms_publisher = bms.freya_bms_node:main'
+            'freya_bms_publisher_node = bms.freya_bms_publisher_node:main'
         ],
     },
 )