fix: typing on IconComponent (#241)

* fix: typing on IconComponent * fixing some type issues with @expo --------- Co-authored-by: Murray Christopherson <[email protected]>
vonovak · Aug 21, 2024 · b87abb1 · b87abb1
1 parent 7428e08
commit b87abb1
Show file tree

Hide file tree

Showing 2 changed files with 14 additions and 7 deletions.
diff --git a/src/HeaderButton.tsx b/src/HeaderButton.tsx
@@ -15,12 +15,19 @@ import type { ComponentProps, ReactNode } from 'react';
 export type VisibleButtonProps = {
   title: string;
 
-  IconComponent?: React.ComponentType<{
-    name: any; // TODO generify to support icon names
-    style?: any;
-    color?: ColorValue;
-    size?: number;
-  }>;
+  IconComponent?:
+    | React.ComponentType<{
+        name: any; // TODO generify to support icon names
+        style?: any;
+        size?: number;
+        color?: ColorValue;
+      }>
+    | React.ComponentType<{
+        name: any; // TODO generify to support icon names
+        style?: any;
+        size?: number;
+        color?: ColorValue | number;
+      }>;
   iconName?: string;
   iconSize?: number;
   color?: ColorValue;

diff --git a/src/__tests__/HeaderButtons.test.tsx b/src/__tests__/HeaderButtons.test.tsx
@@ -71,7 +71,7 @@ describe('HeaderButtons', () => {
     const IoniconsHeaderButton = (props: HeaderButtonProps) => (
       <HeaderButton
         {...props}
-        IconComponent={({ name }) => <Text>{name}</Text>}
+        IconComponent={({ name }: { name: any }) => <Text>{name}</Text>}
         iconSize={23}
         color="blue"
       />