Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve #13

Open
wants to merge 9 commits into
base: master
Choose a base branch
from
Open

Improve #13

wants to merge 9 commits into from

Conversation

toxix
Copy link

@toxix toxix commented Mar 21, 2015

Have done some improvments

  • store and remove the html5 required attribute when the dependent-field is hidden (This could the form from submitting with no proper error messages for the user)
  • Change the default behavier to hide and disable (This prevents the hidden fields from beeing submitted), old behavier is still archivable
  • store the disabled status before hiding and restore when show
  • clean up the filter('[data-important]') and not('[data-important]') (Can't see way they are usefull? Will initialize anyway, so remove them)

sorry for putting everything together in a big pull request. If you have questions or just want to pull in parts feel free to do so.

@vollnhals
Copy link
Owner

Thanks for the improvements @toxix. I will have to look into the changes when I have time.

@toxix toxix force-pushed the improve branch 2 times, most recently from 0dff3e0 to 65838bc Compare January 6, 2016 15:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants