Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP (no active development) - New talktorial: T030: Compound data acquisition from GtoPDB #257

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

dominiquesydow
Copy link
Collaborator

@dominiquesydow dominiquesydow commented Aug 1, 2022

Details - new talktorial

  • Talktorial ID: T029
  • Title: Compound data acquisition from GtoPDB
  • Original authors: @dominiquesydow

Content TODOs

  • GtoPDB background
  • Show case programmatic access
  • Define use case
  • How to select all kinases from gtopdb_targets?
  • Group bioactivity table by ligand ID to show bioactivity ranges per ligand?

Content checklist

  • Potential labels or categories (e.g. machine learning, small molecules, online APIs): XXXXXXXX
  • One line summary: XXXXXXXXXX
  • I have used the talktorial template and followed the formatting suggested there
  • The table of contents reflects the talktorial story-line; order of #, ##, ### headers is correct
  • URLs are linked with meaningful words, instead of pasting the URL directly or linking words like here.
  • I have spell-checked the notebook
  • Images have enough resolution to be rendered with quality, without being too heavy.
  • All figures have a description
  • Markdown cell content is still in-line with code cell output (whenever results are discussed)
  • I have checked that cell outputs are not incredibly long (this applies also to DataFrames)
  • Formatting looks correctly on the Sphinx render (bold, italics, figure placing)

Code checklist

  • Time it took to execute (approx.):
  • Variable and function names follow snake case rules (e.g. a_variable_name vs aVariableName)
  • Spacing follows PEP8 (run Black on the code cells if needed)
  • Code line are under 99 characters each (run black -l 99)
  • Comments are useful and well placed
  • There are no unpythonic idioms like for i in range(len(list)) (see slides)
  • All 3rd party dependencies are listed at the top of the notebook
  • I have marked all code cell with output referenced in markdown cells with the label # NBVAL_CHECK_OUTPUT
  • I have identified potential candidates for a code refactor / useful functions
  • All import ... lines are at the top (practice part) cell, ordered by standard library / 3rd party packages / our own (teachopencadd.*)
  • I have update the relative paths to absolute paths.
    HERE = Path(_dh[-1])
    DATA = HERE / "data"
  • List here unfamiliar libraries you find in the imports and their intended use:

Before merging

  • Revert the changes in the CI: e36ee62

@review-notebook-app
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@dominiquesydow dominiquesydow added the new talktorial New talktorial label Aug 1, 2022
@dominiquesydow dominiquesydow changed the title T030 - Compound data acquisition from GtoPDB T030: Compound data acquisition from GtoPDB Aug 1, 2022
@AndreaVolkamer AndreaVolkamer changed the title T030: Compound data acquisition from GtoPDB WIP (no active development) - New talktorial: T030: Compound data acquisition from GtoPDB May 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
new talktorial New talktorial
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant