Add proper exception handling in file descriptor enumeration #1514
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ikelos
reviewed
Jan 5, 2025
| @@ -307,15 +307,23 @@ def files_descriptors_for_process( | |||
| symbol_table: str, | |||
| task: interfaces.objects.ObjectInterface, | |||
| ): | |||
| # task.files can be null | |||
| if not (task.files and task.files.is_readable()): | |||
| try: | |||
There was a problem hiding this comment.
This doesn't need the exception handler setting up twice, all the calls can happen with the try/except and any failure within that block will result in a return None.
atcuno
force-pushed
the
file_descriptors_exception_handling
branch
from
b6f6c72 to
e6f9ddb
Compare
|
feedback addressed now @ikelos |
|
I meant more that the single exception handler should span to encompass both methods (and anything in between). Do we know that the second files call won't throw an exception? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The lack of exception handling caused backtraces in multiple plugins over 50+ samples. These cleans up those missing checks.