Windows: Update get_commit_charge extension to handle Core.CommitCharge case #1407
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
|
Marked as draft while waiting for @KQBTD |
|
Hopefully it works as intended.... :D |
|
This is still draft. Is it set for primetime? |
|
I think it might be good, now that I've had a sample I could test on #1519 (comment) |
|
If it comes up in the future these changes were tested against the following versions:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello 👋
This will hopefully fix #1400 - however I do not have a sample to test with. Please wait until @KQBTD is able to confirm.
This changes the windows extension for get_commit_charge to handle the case where the results we're after are stored in
Core.CommitChargeas pointed out by @atcuno.Thanks!
🦊