-
Notifications
You must be signed in to change notification settings - Fork 550
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feature: set custom table name for insertion #1375
base: master
Are you sure you want to change the base?
Conversation
c9e4485
to
4064e81
Compare
@stephenafamo please take a look,, thanks! |
4064e81
to
07b90f1
Compare
What is the use case for this? |
for database sharding, for large datasets we need to move these data in different tables with the same schema |
this is the related ticket (discussion) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Still not sure about this use case for most users, but I have a few proposed changes to the PR.
Instead of making this change to SQLBoiler, did you consider having extra templates to add an extra method to the models? |
Thank you for the suggestion. I have considered the template approach, but it seems overly complex for this particular need. Given SQLBoiler's status as a modern ORM tool, I believe incorporating native support for database sharding would significantly enhance its utility for projects requiring robust scalability. This feature would not only simplify development but also align SQLBoiler with the evolving demands of large-scale applications. If SQLBoiler is unable to support this functionality, I may need to explore other solutions that offer built-in sharding capabilities to meet the scalability requirements of my project. I hope we can keep SQLBoiler as our primary ORM tool and avoid the need to switch. |
07b90f1
to
885eae9
Compare
Or maybe you prefer other API design? maybe we can discuss? |
The API looks good. For now, since this is not a very common usecase, I would suggest putting it behind a generation flag. If you can do that, I'll be happy to merge. |
Sure! I am willing to do that Thanks! |
No description provided.