no-relationship-funcs flag added #1329
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This is a big change and I am reluctant to merge it because we will then have to maintain this flag indefinitely. |
|
Well. This is a completely reasonable decision. The popularity of this feature is unknown. However, I would like to suggest leaving the template reorganization in the tests from this PR. This will make it possible to easily customize them to achieve the same effect by simply deleting the relationship files. If you accept this, thrn I will make changes soon. |
atzedus
force-pushed
the
no-relationship-funcs
branch
from
0be697e to
73f2bf0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds new model generation functionality with "no-relationship-funcs" flag.
This flag disable generation helper methods for model relationships loaders.
In some situations its better do disable this functionality, rather then getting N+1 problem on code reviews.