Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add official support for Django 5.1 (no code change) #114

Merged
merged 1 commit into from
Oct 15, 2024

Conversation

jairhenrique
Copy link
Contributor

No description provided.

Copy link

codecov bot commented Oct 14, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.37%. Comparing base (2b71787) to head (a214bd0).
Report is 43 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #114      +/-   ##
==========================================
- Coverage   99.72%   98.37%   -1.36%     
==========================================
  Files          10       14       +4     
  Lines         362      430      +68     
==========================================
+ Hits          361      423      +62     
- Misses          1        7       +6     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@codingjoe codingjoe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi there, I appreciate you interested in this package and that you are helping us to keep this package in peak condition <3

Would you mind adding the version classifier to the pyproject.toml-file too? I believe that would be the only thing missing.

Best,
-Joe

@jairhenrique jairhenrique force-pushed the django51 branch 2 times, most recently from 6a5327c to 0f57207 Compare October 14, 2024 14:07
@jairhenrique
Copy link
Contributor Author

Hi there, I appreciate you interested in this package and that you are helping us to keep this package in peak condition <3

Would you mind adding the version classifier to the pyproject.toml-file too? I believe that would be the only thing missing.

Best, -Joe

@codingjoe done!

Copy link
Member

@codingjoe codingjoe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉

@codingjoe codingjoe changed the title Adds support to django 5.1 Add official support for Django 5.1 (no code change) Oct 15, 2024
@codingjoe codingjoe merged commit 85503c5 into voiio:main Oct 15, 2024
14 of 15 checks passed
@jairhenrique jairhenrique deleted the django51 branch October 29, 2024 09:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants