Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New package: ibus-chewing #40710

Closed
wants to merge 1 commit into from
Closed

New package: ibus-chewing #40710

wants to merge 1 commit into from

Conversation

funk443
Copy link
Contributor

@funk443 funk443 commented Nov 23, 2022

New package

Local build testing

  • I built this PR locally for my native architecture, x86_64-glibc

Copy link
Member

@oreo639 oreo639 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One commit per package, and no merge commits.
https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#creating-updating-and-modifying-packages-in-void-by-yourself

You can get rid of an existing commit using git reset HEAD~ or using git rebase -i.

srcpkgs/ibus-array/template Outdated Show resolved Hide resolved
srcpkgs/ibus-chewing/template Outdated Show resolved Hide resolved
srcpkgs/ibus-chewing/template Outdated Show resolved Hide resolved
pkgname=ibus-chewing
version=1.5.1
revision=1
archs="x86_64"
Copy link
Member

@oreo639 oreo639 Nov 23, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why is this restricted to x86_64? (if, for example, it simply cannot be cross compiled, it should instead be marked as nocross)

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This was not resolved, please don't mark it resolved

srcpkgs/ibus-chewing/template Outdated Show resolved Hide resolved
@classabbyamp classabbyamp added the new-package This PR adds a new package label Nov 24, 2022
srcpkgs/ibus-chewing/template Outdated Show resolved Hide resolved
@funk443 funk443 changed the title New package: ibus-chewing, ibus-array: add runtime dep. New package: ibus-chewing Nov 24, 2022
configure_args="-DLIBEXEC_DIR=/usr/libexec"
make_cmd=make
hostmakedepends="git cmake pkg-config findutils gettext-devel"
makedepends="libchewing-devel ibus-devel gob2 libX11-devel gtk+-devel glib-devel"
Copy link
Member

@oreo639 oreo639 Nov 24, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

New gtk2 packages aren't going to be accepted.
And the gtk3 version doesn't have a tagged release.

chewing/ibus-chewing#162
There is an open issue to create a new release, but it has received no response.

Copy link
Contributor Author

@funk443 funk443 Nov 25, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ya, that's why I directly cloned the repo before, instead of downloading the realeases. The git version of the package has been ported to gtk3, but it is not released.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You can get a tarball at a specific commit from GitHub. I don't think this meets quality requirements, it either uses GTK2 or it doesn't have a release.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I just simply fork it, and release the latest commit by myself.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No, that's equivalent to just not using a release. A release is required because the developers know the best when the code is stable and usable. If we packaged the latest commit, we would have to figure out issues on our own and the maintenance burden would be much higher.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh, ok then... What should I do?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's not acceptable right now.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you could ask upstream to make a release

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All right then, sorry for wasting you guys so much time.

@funk443 funk443 closed this Nov 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
new-package This PR adds a new package
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants