-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New package: ibus-chewing #40710
New package: ibus-chewing #40710
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One commit per package, and no merge commits.
https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#creating-updating-and-modifying-packages-in-void-by-yourself
You can get rid of an existing commit using git reset HEAD~
or using git rebase -i
.
pkgname=ibus-chewing | ||
version=1.5.1 | ||
revision=1 | ||
archs="x86_64" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why is this restricted to x86_64? (if, for example, it simply cannot be cross compiled, it should instead be marked as nocross)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This was not resolved, please don't mark it resolved
srcpkgs/ibus-chewing/template
Outdated
configure_args="-DLIBEXEC_DIR=/usr/libexec" | ||
make_cmd=make | ||
hostmakedepends="git cmake pkg-config findutils gettext-devel" | ||
makedepends="libchewing-devel ibus-devel gob2 libX11-devel gtk+-devel glib-devel" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
New gtk2 packages aren't going to be accepted.
And the gtk3 version doesn't have a tagged release.
chewing/ibus-chewing#162
There is an open issue to create a new release, but it has received no response.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ya, that's why I directly cloned the repo before, instead of downloading the realeases. The git version of the package has been ported to gtk3, but it is not released.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You can get a tarball at a specific commit from GitHub. I don't think this meets quality requirements, it either uses GTK2 or it doesn't have a release.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I just simply fork it, and release the latest commit by myself.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No, that's equivalent to just not using a release. A release is required because the developers know the best when the code is stable and usable. If we packaged the latest commit, we would have to figure out issues on our own and the maintenance burden would be much higher.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh, ok then... What should I do?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's not acceptable right now.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
you could ask upstream to make a release
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All right then, sorry for wasting you guys so much time.
New package
Local build testing