Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add options warning for grace/wait periods #17

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Add options warning for grace/wait periods #17

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
ff3889c
add options warning for grace/wait periods
Apr 9, 2020
aab3fea
Merge branch 'master' into validation-on-options
Apr 9, 2020
7a7f135
Merge branch 'master' into validation-on-options
Sep 25, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions svc.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -77,6 +77,11 @@ func New(name, version string, opts ...Option) (*SVC, error) {
}
}

// Validate some options
if s.TerminationWaitPeriod > 0 && s.TerminationGracePeriod <= s.TerminationWaitPeriod {
s.logger.Warn("termination grace period should be greater than termination wait period")
}

return s, nil
}

Expand Down