[aes/rtl] Correct manual operation mode for GCM #17
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andrea-caforio
approved these changes
Jan 9, 2025
This commit cleans up the generation of GCM specific start signals and properly handles manual operation mode for GCM. Previously, some GCM phases (especially the ones not using the AES cipher core) would start automatically despite the module being configured in manual operation mode. Signed-off-by: Pirmin Vogel <[email protected]>
vogelpi
force-pushed
the
aes-gcm-fix-idle
branch
from
e9055f5 to
2378a13
Compare
vogelpi
changed the title
|
@nasahlpa it turns out that some GCM phases (especially the ones not using the AES cipher core but the GHASH block only) would start automatically despite the module being configured in manual operation mode. This should now be fixed. I've tested this with a sequence involving multiple AAD and TEXT blocks as well as the tag generation. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.