Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Major/move to typescript vuecli #150

Open
wants to merge 11 commits into
base: master
Choose a base branch
from

Conversation

seriouslag
Copy link

@seriouslag seriouslag commented Sep 14, 2021

This PR is the start of migrating to typescript, exporting type definitions, moving to use vue cli as the bundler for the library, using vue cli as the dev server.

  • Migrated all js to typescript
  • fixed bugs found when using typescript
  • changed package.json main field to commonjs to allow for easier importing for library consumers.
  • changed to use new babel.config.js file
  • removed need to commit bulma styles, will be installed from package.json for dev work
  • Changed default export to a Vue plugin install function
  • Named exporting the needed types and component

Note dist files will need to be created by a CI pipeline since I removed them from the repo

@seriouslag
Copy link
Author

@AlexMordred would you care to take a look at this PR :)

@Grawl
Copy link

Grawl commented Sep 23, 2021

@seriouslag in #132 (comment), Alex says:

Unfortunately, I am not familiar with TypeScript as of now

So, I think we must follow some checklist, like so:

  • it working without changes after switching to PR branch and installing dependencies
  • it have no type errors
  • ...and so on

@seriouslag
Copy link
Author

@Grawl

Would you care to add more?

Are you experiencing any issues when you pull the branch and install deps?

I am not seeing any issues on my end.
I published the changes to a package to use on my project until these get moved.

https://www.npmjs.com/package/@seriouslag/vue-tagsinput

@Grawl
Copy link

Grawl commented Sep 24, 2021

Just tested it and it works

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants