Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allowing options to be set #118

Merged
merged 3 commits into from
Nov 28, 2023
Merged

Allowing options to be set #118

merged 3 commits into from
Nov 28, 2023

Conversation

nigeon
Copy link
Contributor

@nigeon nigeon commented Nov 27, 2023 •
edited
Loading

Initial proposal, want to discuss:

  1. We prob. should create a type for those options, unless we don't want options but specifics properties.
  2. I think "token_limit" SDK faucet prop. shouldn't be required on the SDK
  3. Maybe we should new VocdoniSDKClient(....) in a way we don't repeat ourselves 3 times

Related: #87
and vocdoni/vocdoni-sdk#243

@nigeon nigeon requested a review from elboletaire November 27, 2023 16:17
@nigeon
ClientReducerPropsOptions
d00025f 
Moved SDKClient creation to func.
@nigeon
Upgraded SDK to 0.5.3
9cf4b64 
Removed the (now optional) token_limit
@nigeon nigeon marked this pull request as ready for review November 28, 2023 13:37
@nigeon nigeon merged commit 231808f into main Nov 28, 2023
1 check passed
@elboletaire elboletaire mentioned this pull request Nov 28, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@elboletaire elboletaire elboletaire approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nigeon @elboletaire