[feat] update error handler for api update secgroup for server

vngcloud · Jun 7, 2024 · cbdb64d · cbdb64d
1 parent c44d26c
commit cbdb64d
Show file tree

Hide file tree

Showing 3 changed files with 18 additions and 0 deletions.
diff --git a/vngcloud/sdk_error/error_codes.go b/vngcloud/sdk_error/error_codes.go
@@ -81,6 +81,7 @@ const (
 const (
 	EcVServerServerNotFound                       = ErrorCode("VngCloudVServerServerNotFound")
 	EcVServerServerDeleteCreatingServer           = ErrorCode("VngCloudVServerServerDeleteCreatingServer")
+	EcVServerServerExpired                        = ErrorCode("VngCloudVServerServerExpired")
 	EcVServerServerExceedQuota                    = ErrorCode("VngCloudVServerServerExceedQuota")
 	EcVServerServerDeleteDeletingServer           = ErrorCode("VngCloudVServerServerDeleteDeletingServer")
 	EcVServerServerDeleteBillingServer            = ErrorCode("VngCloudVServerServerDeleteBillingServer")

diff --git a/vngcloud/sdk_error/server.go b/vngcloud/sdk_error/server.go
@@ -11,6 +11,7 @@ const (
 	patternBillingPaymentMethodNotAllowed  = "payment method is not allowed for the user"
 	patternServerAttachVolumeQuotaExceeded = "exceeded volume_per_server quota"
 	patternServerAttachEncryptedVolume     = "cannot attach encryption volume"
+	patternServerExpired                   = "server is expired"
 )
 
 func WithErrorServerNotFound(perrResp IErrorRespone) func(sdkError ISdkError) {
@@ -43,6 +44,21 @@ func WithErrorServerDeleteCreatingServer(perrResp IErrorRespone) func(sdkError I
 	}
 }
 
+func WithErrorServerExpired(perrResp IErrorRespone) func(sdkError ISdkError) {
+	return func(sdkError ISdkError) {
+		if perrResp == nil {
+			return
+		}
+
+		errMsg := perrResp.GetMessage()
+		if lstr.Contains(lstr.ToLower(lstr.TrimSpace(errMsg)), patternServerExpired) {
+			sdkError.WithErrorCode(EcVServerServerExpired).
+				WithMessage(errMsg).
+				WithErrors(perrResp.GetError())
+		}
+	}
+}
+
 func WithErrorServerExceedQuota(perrResp IErrorRespone) func(sdkError ISdkError) {
 	return func(sdkError ISdkError) {
 		if perrResp == nil {

diff --git a/vngcloud/services/compute/v2/server.go b/vngcloud/services/compute/v2/server.go
@@ -83,6 +83,7 @@ func (s *ComputeServiceV2) UpdateServerSecgroupsByServerId(popts IUpdateServerSe
 	if _, sdkErr := s.VServerClient.Put(url, req); sdkErr != nil {
 		return nil, lserr.SdkErrorHandler(sdkErr, errResp,
 			lserr.WithErrorServerNotFound(errResp),
+			lserr.WithErrorServerExpired(errResp),
 			lserr.WithErrorSecgroupNotFound(errResp)).
 			WithKVparameters("projectId", s.getProjectId(),
 				"serverId", popts.GetServerId(),