made pricing api calls region specific + initDB #1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@mohamedlajmileanix please review changes and merge after finishing |
vg-leanix
commented
Jul 22, 2021
| @@ -19,6 +19,26 @@ | |||
| pricing_dict = {} | |||
| region_table = {} | |||
| container_instance_ec2_mapping = {} | |||
| aws_regions = { | |||
There was a problem hiding this comment.
we need this to map region to region name to use it as param for Pricing API calls
vg-leanix
commented
Jul 22, 2021
| """ | ||
| svc_code = 'AmazonEC2' | ||
| region_name = str(aws_regions[region]) | ||
| client = boto3.client('pricing', region_name="us-east-1") |
There was a problem hiding this comment.
we need to hard code the pricing api endpoint but make the region specific in the location param in the query
vg-leanix
commented
Jul 22, 2021
| @@ -93,7 +122,9 @@ def ec2_pricing(region, instance_type, tenancy, ostype): | |||
| ret_dict['pricePerUnit'] = mydict_terms['priceDimensions'][list( | |||
| mydict_terms['priceDimensions'].keys())[0]]['pricePerUnit'] | |||
| ret_list.append(ret_dict) | |||
|
|
|||
| else: | |||
There was a problem hiding this comment.
added improved logging for cases where we do not get pricing info - can still happen
vg-leanix
commented
Jul 22, 2021
| table = db_res.Table("initDB") | ||
|
|
||
| #db_client = boto3.client('dynamodb') | ||
| initialised = table.scan( |
There was a problem hiding this comment.
pls check if this query works properly
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.