Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed local file hinting not working for folder names containing dash #146

Merged
merged 7 commits into from
May 30, 2024

Conversation

MirjanaStojanoska
Copy link
Contributor

@MirjanaStojanoska MirjanaStojanoska commented Apr 25, 2024

Description

Fix for the hinting functionality when in the folder name there is a dash sign ("-").

Checklist

  • Lint and unit tests pass locally with my changes

Testing

Open a java script action and try to write

System.getModule("com.module.path.module-with-dash").

Release Notes

  • Enable hinting on vRO and locally loaded modules / actions for modules that have - in their names.

Screenshot

436855831_3563977883914947_4932449964221266178_n

Related issues and PRs

@MirjanaStojanoska MirjanaStojanoska requested a review from a team as a code owner April 25, 2024 13:18
Remove the node version 14.x (as it is obsolete)
@vmware vmware deleted a comment from vmwclabot Apr 25, 2024
@vmware vmware deleted a comment from vmwclabot Apr 25, 2024
akantchev
akantchev previously approved these changes May 28, 2024
Signed-off-by: Alexander Kantchev <[email protected]>
@vmwclabot
Copy link
Member

@MirjanaStojanoska, you must sign every commit in this pull request acknowledging our Developer Certificate of Origin before your changes are merged. This can be done by adding Signed-off-by: John Doe <[email protected]> to the last line of each Git commit message. The e-mail address used to sign must match the e-mail address of the Git author. Click here to view the Developer Certificate of Origin agreement.

Signed-off-by: Alexander Kantchev <[email protected]>
@vmwclabot
Copy link
Member

@MirjanaStojanoska, you must sign every commit in this pull request acknowledging our Developer Certificate of Origin before your changes are merged. This can be done by adding Signed-off-by: John Doe <[email protected]> to the last line of each Git commit message. The e-mail address used to sign must match the e-mail address of the Git author. Click here to view the Developer Certificate of Origin agreement.

Signed-off-by: Alexander Kantchev <[email protected]>
@vmwclabot
Copy link
Member

@MirjanaStojanoska, you must sign every commit in this pull request acknowledging our Developer Certificate of Origin before your changes are merged. This can be done by adding Signed-off-by: John Doe <[email protected]> to the last line of each Git commit message. The e-mail address used to sign must match the e-mail address of the Git author. Click here to view the Developer Certificate of Origin agreement.

VenelinBakalov
VenelinBakalov previously approved these changes May 30, 2024
Signed-off-by: Alexander Kantchev <[email protected]>
@vmwclabot
Copy link
Member

@MirjanaStojanoska, you must sign every commit in this pull request acknowledging our Developer Certificate of Origin before your changes are merged. This can be done by adding Signed-off-by: John Doe <[email protected]> to the last line of each Git commit message. The e-mail address used to sign must match the e-mail address of the Git author. Click here to view the Developer Certificate of Origin agreement.

@VenelinBakalov VenelinBakalov merged commit f290f60 into master May 30, 2024
3 checks passed
@VenelinBakalov VenelinBakalov deleted the hinting-for-folder-name-with-dash branch May 30, 2024 14:48
@VenelinBakalov VenelinBakalov added type:bug Something isn't working patch and removed dco-required labels Jul 4, 2024
@VenelinBakalov VenelinBakalov changed the title fixed hinting for folder name with dash in it Fixed local file hinting not working for folder names containing dash Jul 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
patch type:bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants