Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[No Review]Test hostname for vic #8639

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

[No Review]Test hostname for vic #8639

wants to merge 2 commits into from

Conversation

ading007
Copy link

@ading007 ading007 commented Jun 1, 2020

testing.

@hickeng
Handle lint errors in generated serivce code
62a0aea 
This adds the generated VIC service bindings to the ingore
set for linting due to package names containing underscores.
This will present on all but the first build in a given build
env.
@hickeng
Name field is guest visible
1a5aa2e 
The Name field was changed to be hidden from the guest in vmware#4134 to
support docker rename. This was a compromise needed due to an ESX
vigor bug, see vmware#5533.

This *requires* that users be on a version of ESX that has the fix
or bad things may happen to cVM configurations. I have not tracked
down what build versions that entails and have not code a check
mechanism.

This change has the effect of the hostname of the VCH endpointVM
being set to the name of the VCH.
It also allows additional live reconfiguration such as hotadd to
a bridge network, in general modification of all container
configuration live is possible, if not necessarily applied.
@ading007 ading007 requested a review from a team as a code owner June 1, 2020 09:51
@hickeng
Copy link
Member

hickeng commented Jun 1, 2020

I don't think we should merge this as is.
It was a hypothesis for bug2555488 - I've put the shortest path to fix that into the bug report.

This change is not sufficient on it's own. While the guestinfo conversion to volatile issue has been fixed, the semantics are still not correct for what we want. A docker rename will change the name while the VM is powered on, but modifying the value while the VM is powered on overlays a volatile value and when the VM powers off the value reverts. That leaves us with a renamed VM in VC inventory, but incorrectly reporting the old name via docker.
The only option I can see to progress this approach is to have both this guest visible field, and the hidden field that can be modified while VM is powered on, with a check to copy from hidden to read-only that occurs after power off and during endpoint initialization. That's likely too heavy weight for the benefits at this time.

Fixing vmware/govmomi#2000 should be the priority, as without that it doesn't matter what the hostname is set to.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
cla-not-required
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ading007 @hickeng @vmwclabot