-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add name option to d/domain
#228
feat: add name option to d/domain
#228
Conversation
8d23514
to
675f3f8
Compare
675f3f8
to
1cccf01
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It looks like the file data_source_domain_test.go doesn't compile. Please, fix it and then run the acceptance tests for domain data source and post the result in the MR description.
this is already in comments and will be looked at.
|
4eb55dd
to
f22fd50
Compare
d/domain
d/domain
d/domain
f22fd50
to
ad09229
Compare
c3d01ed
to
ba9e5d5
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Verified the tests (see summary) and pushed an update to include updates to the Description
fields for clarifty and readability.
LGTM! 🚀
164d668
Updated `d/vcf_domain` to support `name` alongside the existing `domain_id`. Signed-off-by: Jared Burns <[email protected]> Co-Authored-By: Ryan Johnson <[email protected]>
164d668
to
e719195
Compare
I'm going to lock this pull request because it has been closed for 30 days. This helps our maintainers find and focus on the active issues. If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further. |
In order to have a good experience with our community, we recommend that you read the contributing guidelines for making a pull request.
Summary of Pull Request
Updated
d/vcf_domain
to supportname
alongside the existingdomain_id
.Type of Pull Request
Please describe:
Related to Existing Issues
Closes #207
Test and Documentation Coverage
For bug fixes or features:
✅
TestAccDataSourceVcfDomainByID
✅
TestAccDataSourceVcfDomainByName
Breaking Changes?