Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add name option to d/domain #228

Merged

Conversation

burnsjared0415
Copy link
Contributor

@burnsjared0415 burnsjared0415 commented Aug 20, 2024

In order to have a good experience with our community, we recommend that you read the contributing guidelines for making a pull request.

Summary of Pull Request

Updated d/vcf_domain to support name alongside the existing domain_id.

Type of Pull Request

  • This is a bug fix.
  • This is an enhancement or feature.
  • This is a code style/formatting update.
  • This is a documentation update.
  • This is a refactoring update.
  • This is a chore update
  • This is something else.
    Please describe:

Related to Existing Issues

Closes #207

Test and Documentation Coverage

For bug fixes or features:

  • Tests have been completed.
  • Documentation has been added/updated.

TestAccDataSourceVcfDomainByID

Running tool: /usr/local/bin/go test -timeout 30s -run ^TestAccDataSourceVcfDomainById$ github.com/vmware/terraform-provider-vcf/internal/provider

ok  	github.com/vmware/terraform-provider-vcf/internal/provider	0.969s

TestAccDataSourceVcfDomainByName

Running tool: /usr/local/bin/go test -timeout 30s -run ^TestAccDataSourceVcfDomainByName$ github.com/vmware/terraform-provider-vcf/internal/provider

ok  	github.com/vmware/terraform-provider-vcf/internal/provider	0.776s

Breaking Changes?

  • Yes, there are breaking changes.
  • No, there are no breaking changes.

@github-actions github-actions bot added documentation Documentation needs-review Needs Review provider Provider labels Aug 20, 2024
@tenthirtyam tenthirtyam marked this pull request as draft August 20, 2024 15:58
@burnsjared0415 burnsjared0415 force-pushed the feat/add-domain-name-to-data-resource branch 2 times, most recently from 8d23514 to 675f3f8 Compare August 20, 2024 16:04
@tenthirtyam tenthirtyam added this to the v0.11.0 milestone Aug 20, 2024
@tenthirtyam tenthirtyam force-pushed the feat/add-domain-name-to-data-resource branch from 675f3f8 to 1cccf01 Compare August 20, 2024 18:43
Copy link
Contributor

@dimitarproynov dimitarproynov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks like the file data_source_domain_test.go doesn't compile. Please, fix it and then run the acceptance tests for domain data source and post the result in the MR description.

internal/provider/data_source_domain.go Outdated Show resolved Hide resolved
internal/provider/data_source_domain.go Outdated Show resolved Hide resolved
internal/provider/data_source_domain_test.go Outdated Show resolved Hide resolved
@burnsjared0415
Copy link
Contributor Author

burnsjared0415 commented Aug 21, 2024 via email

@burnsjared0415 burnsjared0415 force-pushed the feat/add-domain-name-to-data-resource branch 2 times, most recently from 4eb55dd to f22fd50 Compare August 21, 2024 14:40
@tenthirtyam tenthirtyam changed the title feat: add domain name to data source feat: add name to d/domain Aug 21, 2024
@tenthirtyam tenthirtyam changed the title feat: add name to d/domain feat: add name option to d/domain Aug 21, 2024
@tenthirtyam tenthirtyam force-pushed the feat/add-domain-name-to-data-resource branch from f22fd50 to ad09229 Compare August 21, 2024 17:31
@tenthirtyam tenthirtyam marked this pull request as ready for review August 21, 2024 17:31
@tenthirtyam tenthirtyam force-pushed the feat/add-domain-name-to-data-resource branch 3 times, most recently from c3d01ed to ba9e5d5 Compare August 21, 2024 18:20
tenthirtyam
tenthirtyam previously approved these changes Aug 21, 2024
Copy link
Collaborator

@tenthirtyam tenthirtyam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Verified the tests (see summary) and pushed an update to include updates to the Description fields for clarifty and readability.

LGTM! 🚀

@tenthirtyam tenthirtyam removed the needs-review Needs Review label Aug 21, 2024
dimitarproynov
dimitarproynov previously approved these changes Aug 22, 2024
@tenthirtyam tenthirtyam dismissed stale reviews from dimitarproynov and themself via 164d668 August 22, 2024 08:12
@vmwclabot vmwclabot added the dco-required DCO Required label Aug 22, 2024
@github-actions github-actions bot added the needs-review Needs Review label Aug 22, 2024
Updated `d/vcf_domain` to support `name` alongside the existing `domain_id`.

Signed-off-by: Jared Burns <[email protected]>
Co-Authored-By: Ryan Johnson <[email protected]>
@tenthirtyam tenthirtyam force-pushed the feat/add-domain-name-to-data-resource branch from 164d668 to e719195 Compare August 22, 2024 13:48
@vmwclabot vmwclabot removed the dco-required DCO Required label Aug 22, 2024
@tenthirtyam tenthirtyam removed the needs-review Needs Review label Aug 22, 2024
@vmware vmware deleted a comment from vmwclabot Aug 22, 2024
@tenthirtyam tenthirtyam merged commit 6aa3067 into vmware:main Aug 22, 2024
3 checks passed
Copy link

I'm going to lock this pull request because it has been closed for 30 days. This helps our maintainers find and focus on the active issues.

If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 22, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
documentation Documentation provider Provider
Projects
None yet
Development

Successfully merging this pull request may close these issues.

d/domain: add support to use name
4 participants