chore: update copyright and spdx

[tenthirtyam]

Summary of Pull Request

As discussed with Chip Childers:

• Updates or adds the Broadcom copyright, as needed.
• Updates or adds the SPDX-License-Identifier, as needed.
• Removes whitespace as noted.

Go:

// © Broadcom. All Rights Reserved.
// The term "Broadcom" refers to Broadcom Inc. and/or its subsidiaries.
// SPDX-License-Identifier: MPL-2.0

Python:

# © Broadcom. All Rights Reserved.
# The term "Broadcom" refers to Broadcom Inc. and/or its subsidiaries.
# SPDX-License-Identifier: MPL-2.0

Type of Pull Request

• This is a bug fix.
• This is an enhancement or feature.
• This is a code style/formatting update.
• This is a documentation update.
• This is a refactoring update.
• This is a chore update
• This is something else.
  Please describe:

Related to Existing Issues

Test and Documentation Coverage

For bug fixes or features:

• Tests have been completed.
• Documentation has been added/updated.

Breaking Changes?

• Yes, there are breaking changes.
• No, there are no breaking changes.

[ksamoray]

@tenthirtyam note that we have a feature branch, vpc20-feature-branch, which adds a whole bunch of other files which should be modified as well.
IDK what's the best approach here - wait with such change until we merge vpc20-feature-branch into master, modify the addl files in the feature branch or cherry-pick this into the feature branch... Maybe @annakhm or @salv-orlando have a suggestion here.

[tenthirtyam]

Hey @ksamora - 👋 I'd suggest waiting until the vpc20-feature-branch branch is merged and we can then rebase this branch and update any additional files that need the updates from vpc20-feature-branch to keep in all in one related change.

Ryan

[salv-orlando]

@ksamoray It seems the linter error reported here is valid.
Probably not flagged by other PRs because they're not touching this file?

[salv-orlando]

@tenthirtyam after merging branch vpc20-feature-branch, we added multiple files such as nsxt/resource_nsxt_vpc_subnet.go

These files already have the broadcom copyright header but it's not the same as the one being added here.
Perhaps it might be worth refreshing this PR to ensure the header is updated for all code modules?

[tenthirtyam]

Sure. I'll review and update these to align.

[tenthirtyam]

@salv-orlando - updated the new files in 29654e3.

[ksamoray]

@ksamoray It seems the linter error reported here is valid. Probably not flagged by other PRs because they're not touching this file?

Indeed, we can remove that func.
I'll submit a PR.

[ksamoray]

Old copyright still appears in a bunch of files, e.g:

./tools/diffy/diffy.py:# Copyright (c) 2023 VMware, Inc. All Rights Reserved.
./nsxt/data_source_nsxt_vpc_service_profile.go:/* Copyright © 2020 VMware, Inc. All Rights Reserved.
./nsxt/data_source_nsxt_policy_gateway_connection.go:/* Copyright © 2022 VMware, Inc. All Rights Reserved.
./nsxt/data_source_nsxt_policy_distributed_vlan_connection.go:/* Copyright © 2022 VMware, Inc. All Rights Reserved.
./nsxt/data_source_nsxt_policy_transit_gateway.go:/* Copyright © 2020 VMware, Inc. All Rights Reserved.
./nsxt/data_source_nsxt_vpc_group.go:/* Copyright © 2020 VMware, Inc. All Rights Reserved.
./nsxt/data_source_nsxt_vpc_connectivity_profile.go:/* Copyright © 2020 VMware, Inc. All Rights Reserved.

[tenthirtyam]

I'll take another pass today.

[tenthirtyam]

Old copyright still appears in a bunch of files, e.g:

./tools/diffy/diffy.py:# Copyright (c) 2023 VMware, Inc. All Rights Reserved. ./nsxt/data_source_nsxt_vpc_service_profile.go:/* Copyright © 2020 VMware, Inc. All Rights Reserved. ./nsxt/data_source_nsxt_policy_gateway_connection.go:/* Copyright © 2022 VMware, Inc. All Rights Reserved. ./nsxt/data_source_nsxt_policy_distributed_vlan_connection.go:/* Copyright © 2022 VMware, Inc. All Rights Reserved. ./nsxt/data_source_nsxt_policy_transit_gateway.go:/* Copyright © 2020 VMware, Inc. All Rights Reserved. ./nsxt/data_source_nsxt_vpc_group.go:/* Copyright © 2020 VMware, Inc. All Rights Reserved. ./nsxt/data_source_nsxt_vpc_connectivity_profile.go:/* Copyright © 2020 VMware, Inc. All Rights Reserved.

Resolved in 21e2764 => Compare