Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix bugs of localized numbers #2980

Merged

Conversation

Xiaochao8
Copy link
Contributor

No description provided.

@Xiaochao8 Xiaochao8 enabled auto-merge (squash) January 23, 2024 03:14
Copy link

codecov bot commented Jan 23, 2024

Codecov Report

Attention: 4 lines in your changes are missing coverage. Please review.

Comparison is base (4477f00) 79.59% compared to head (0a325cc) 79.39%.

Files Patch % Lines
api/v2/formatting/handler_formatting.go 84.61% 3 Missing and 1 partial ⚠️
Additional details and impacted files
@@                 Coverage Diff                 @@
##           g11n-go-service    #2980      +/-   ##
===================================================
- Coverage            79.59%   79.39%   -0.21%     
===================================================
  Files                   59       61       +2     
  Lines                 3274     3363      +89     
===================================================
+ Hits                  2606     2670      +64     
- Misses                 534      556      +22     
- Partials               134      137       +3     
Flag Coverage Δ
coverage 79.39% <84.61%> (-0.21%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

modules/cldr/constants.go Dismissed Show dismissed Hide dismissed
@Xiaochao8 Xiaochao8 removed the request for review from linr211 February 1, 2024 02:37
@Xiaochao8 Xiaochao8 enabled auto-merge (squash) February 1, 2024 02:42
@Xiaochao8 Xiaochao8 merged commit 6528948 into vmware:g11n-go-service Feb 20, 2024
20 checks passed
@Xiaochao8 Xiaochao8 deleted the g11n-go-service_localizednum2 branch February 20, 2024 06:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants