Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

get correct language tags in uiListOrMenu and Standalone to fix #2925 #2926

Merged

Conversation

Xiaochao8
Copy link
Contributor

No description provided.

@Xiaochao8 Xiaochao8 enabled auto-merge (squash) December 18, 2023 07:00
modules/cldr/constants.go Dismissed Show dismissed Hide dismissed
modules/cldr/localeutil/utils.go Fixed Show fixed Hide fixed
Copy link

codecov bot commented Dec 18, 2023

Codecov Report

Attention: 3 lines in your changes are missing coverage. Please review.

Comparison is base (0b12320) 79.77% compared to head (cbdcd5c) 79.74%.

Files Patch % Lines
modules/cldr/localeutil/utils.go 66.66% 3 Missing ⚠️
Additional details and impacted files
@@                 Coverage Diff                 @@
##           g11n-go-service    #2926      +/-   ##
===================================================
- Coverage            79.77%   79.74%   -0.04%     
===================================================
  Files                   59       59              
  Lines                 3259     3268       +9     
===================================================
+ Hits                  2600     2606       +6     
- Misses                 525      528       +3     
  Partials               134      134              
Flag Coverage Δ
coverage 79.74% <80.00%> (-0.04%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

modules/cldr/localeutil/utils.go Dismissed Show dismissed Hide dismissed
@Xiaochao8 Xiaochao8 merged commit 3c64756 into vmware:g11n-go-service Dec 19, 2023
21 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants