Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixed the lost key issue #2890

Merged
merged 3 commits into from
Jan 11, 2024
Merged

fixed the lost key issue #2890

merged 3 commits into from
Jan 11, 2024

Conversation

tigershi
Copy link
Contributor

@tigershi tigershi commented Dec 6, 2023

No description provided.

Copy link

codecov bot commented Dec 6, 2023

Codecov Report

Attention: 136 lines in your changes are missing coverage. Please review.

Comparison is base (b47cb10) 52.48% compared to head (16a6819) 50.92%.

Files Patch % Lines
...m/vmware/l10n/source/dao/impl/S3SourceDaoImpl.java 0.00% 134 Missing ⚠️
...ource/service/impl/SyncLocalBundleServiceImpl.java 33.33% 2 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##             master    #2890      +/-   ##
============================================
- Coverage     52.48%   50.92%   -1.57%     
+ Complexity      394      393       -1     
============================================
  Files            68       68              
  Lines          2376     2445      +69     
  Branches        293      299       +6     
============================================
- Hits           1247     1245       -2     
- Misses          968     1041      +73     
+ Partials        161      159       -2     
Flag Coverage Δ
vip-manager-i18n 47.11% <ø> (ø)
vip-manager-l10n 46.79% <0.72%> (-2.08%) ⬇️
vip-manager-lite-i18n 71.85% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@tigershi tigershi merged commit 51cdbc4 into vmware:master Jan 11, 2024
24 checks passed
@tigershi tigershi deleted the vl10n branch January 29, 2024 09:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants