enable authentication #2887
enable authentication #2887
Conversation
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## g11n-go-service #2887 +/- ##
===================================================
+ Coverage 79.72% 79.77% +0.05%
===================================================
Files 56 59 +3
Lines 3058 3259 +201
===================================================
+ Hits 2438 2600 +162
- Misses 505 525 +20
- Partials 115 134 +19
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
There was a problem hiding this comment.
Revive (reported by Codacy) found more than 10 potential problems in the proposed changes. Check the Files changed tab for more details.
Xiaochao8
force-pushed
the
g11n-go-service_auth
branch
from
1da5c36 to
d84df22
Compare
|
Because of the PR change a lot, Can you book a short meeting to review the PR |
| } | ||
|
|
||
| var GetLDAPConn = func() (ldap.Client, error) { | ||
| tlsConfig := tls.Config{MinVersion: tls.VersionTLS13, InsecureSkipVerify: true} |
Check warning
Code scanning / Semgrep (reported by Codacy)
Checks for disabling of TLS/SSL certificate verification. Warning
Authentication is enabled on both V1 and V2 APIs.
The same token should be able to use in Java and Go.
This PR makes some changes in S3 bundles, please make sure S3 bundles work normally.