Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ensure that scriptFile is a file #689

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Ensure that scriptFile is a file #689

wants to merge 1 commit into from

Conversation

yunzheng
Copy link

If the scripts directory contained a directory, for example pycache
it would try to execute it. This ensures that we only execute files.

@yunzheng
Ensure that scriptFile is a file
20f8b7b 
If the scripts directory contained a directory, for example __pycache__
it would try to execute it. This ensures that we only execute files.
@vmwclabot
Copy link
Member

@yunzheng, you must sign our contributor license agreement before your changes are merged. Click here to sign the agreement. If you are a VMware employee, read this for further instruction.

@vmwclabot
Copy link
Member

@yunzheng, we have received your signed contributor license agreement. The review is usually completed within a week, but may take longer under certain circumstances. Another comment will be added to the pull request to notify you when the merge can proceed.

@vmwclabot
Copy link
Member

@yunzheng, VMware has rejected your signed contributor license agreement. The merge can not proceed until the agreement has been resigned. Click here to resign the agreement. Reject reason:

Please provide more address detail - Minimum required is Country, State, Town/City.

@vmwclabot
Copy link
Member

@yunzheng, we have received your signed contributor license agreement. The review is usually completed within a week, but may take longer under certain circumstances. Another comment will be added to the pull request to notify you when the merge can proceed.

@vmwclabot
Copy link
Member

@yunzheng, VMware has approved your signed contributor license agreement.

@sever-sever
Copy link

Do you happen to have any updates to this PR?

@vmwkruti1111
Copy link
Contributor

The changes from this pull request has already been incorporated and will be in the next major release of open-vm-tools.
Thanks for submitting the pull request.

@yunzheng
Copy link
Author

No I don’t have any updates. PR should still be applicable.

@vmwkruti1111 good to know, was there a reason why the change was done outside this PR?

@vmwkruti1111
Copy link
Contributor

Thanks again @yunzheng for your contribution, your patch has been accepted with additional modifications.
The change has been made considering this PR only.

@yunzheng
Copy link
Author

Alright, thanks. happy to see it being fixed. PR can be closed then :)

@johnwvmw
Copy link
Contributor

@yunzheng
Our source is maintained in a separate source repository; not directly on the github vmware/open-vm-tools repo. PRs are not directly merged into the github repo. When the actual change is provided on an open-vm-tools github branch, there will be a notification attached to this PR.

We will close this PR after the change shows up on "devel" branch and on the upcoming "stable-12.4.x" branch.

Thanks again for your contribution.

vmwkruti1111 added a commit that referenced this pull request Feb 29, 2024
@vmwkruti1111
Power Ops: Attempt to execute file path only
c199cce 
Adding a check to verify that the path to execute
is a file only and not a directory.

Pull request: #689
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@yunzheng @vmwclabot @sever-sever @vmwkruti1111 @johnwvmw