Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AV-203851 documentation for controlPlaneHmOnly flag #260

Merged
merged 1 commit into from
Dec 22, 2024

Conversation

arihantg
Copy link
Contributor

No description provided.

docs/crds/gdp.md Outdated
@@ -118,12 +121,14 @@ matchRules:

11. `pkiProfileRef`: Provide an PKI Profile ref (pre-created in Avi Controller).This has to be a federated profile. It will be applied only if sitePersistence is enabled.

12. `controlPlaneHmOnly`: If this boolean flag is set to `true` Only control plane health monitoring will be done. Amko will not add any `healthMonitorRefs` or create any data plane health monitors. It is `false` by default.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Amko --> AMKO

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

updated

docs/crds/gdp.md Outdated
@@ -118,12 +121,14 @@ matchRules:

11. `pkiProfileRef`: Provide an PKI Profile ref (pre-created in Avi Controller).This has to be a federated profile. It will be applied only if sitePersistence is enabled.

12. `controlPlaneHmOnly`: If this boolean flag is set to `true` Only control plane health monitoring will be done. Amko will not add any `healthMonitorRefs` or create any data plane health monitors. It is `false` by default.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please change to If ... set to 'true', only control ...

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

updated

Copy link
Contributor

@akshayhavile akshayhavile left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@akshayhavile akshayhavile merged commit 78819e4 into vmware:master Dec 22, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants