fix: Sync the VCDMachine v1beta1 CRD with the go type #514
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A recent PR[1] updated the godoc comment that describes the VCDMachineSpec MachineAddress field, but the change was not reflected in the v1beta1 CRD. This updates the comment in the CRD base, as well as infrastructure-components.yaml [1]: vmware#445
|
@dlipovetsky, you must sign our contributor license agreement before your changes are merged. Click here to sign the agreement. If you are a VMware employee, read this for further instruction. |
|
@dlipovetsky, we have received your signed contributor license agreement. The review is usually completed within a week, but may take longer under certain circumstances. Another comment will be added to the pull request to notify you when the merge can proceed. |
|
@dlipovetsky, VMware has approved your signed contributor license agreement. |
Anirudh9794
approved these changes
Oct 20, 2023
sahithi
approved these changes
Nov 7, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
A recent PR1 updated the godoc comment that describes the VCDMachineSpec MachineAddress field, but the change was not reflected in the v1beta1 CRD.
This PR does not change the CRD schema, only a comment to a field, and therefore does not make any breaking changes.
Checklist
API Changes
Are there API changes?
If yes, please fill in the below
./examples/capi-quickstart.yaml?./infrastructure-vcd/v1.0.0/?Issue
If applicable, please reference the relevant issue
Fixes #
This change is