[maven,typescript] (#332, #462, #463) Update dependencies to latest package versions #582

deyan-r · 2024-12-30T08:52:44Z

Description

Typescript projects were updated to require Node.js 20+(node>=20.18.1, npm>=10.8.2)
All dependencies were updated to the latest versions.
Where needed, the code was updated to be compatible with changes in components interfaces.
Such alignment includes, but not limited to:

all: update dependencies to latest versions and resolve minor issues
polyglotpkg: fs-extra and globby were replaced by fs
vropkg: updated according new uuid and unzipper api; minor differences in expected files
vrotest: fs-extra was replaced by fs
vrotsc: few changes in expected js code generated by the latest version of tsc

Polyglot archetype to set proper runtime values in polyglot.json for sample vro templates.
A few bugs encountered were fixed.

Checklist

I have added relevant error handling and logging messages to help troubleshooting
I have added tests that prove my fix is effective or that my feature works
I have added necessary documentation, relevant usage information (if applicable)
I have updated the PR title with affected component, related issue number and a short summary of the changes introduced
I have added labels for implementation kind (kind/) and version type (version/)
I have tested against live environment, if applicable
I have synced any structure and/or content vRA-NG improvements with vra-ng and ts-vra-ng archetypes (if applicable)
I have my changes rebased and squashed to the minimal number of relevant commits. Notice: don't squash all commits
I have added a descriptive commit message with a short title, including a Fixed #XXX - or Closed #XXX - prefix to auto-close the issue

Testing

Testing included three steps:

Build components and entire BTVA (unit and integration tests passed)
Archetype lifecycle testing: create, build, push, pull
Build and push existing vra/vro projects

Release Notes

Update typescript projects to node.js 20+ and latest versions of dependencies

Related issues and PRs

#463
#462
#332 (duplicated by #464)

Done for component docs/archive/doc. Tested with Node.js version 22.11.0.

Done for component typescript/vro-scripting-api. Tested with Node.js version 22.11.0.

* chore: Updated dependency versions of adm-zip and @types/adm-zip * chore: Updated dependency versions of @types/uuid / uuid. * chore: Updated dependency versions of command-line-args / @types/command-line-args. * chore: Updated dependency version of ts-node

…nv" and "typescript/polyglotpkg" (#3) * chore: Updated dependency versions of adm-zip and @types/adm-zip * chore: Updated dependency versions of @types/uuid / uuid. * chore: Updated dependency versions of command-line-args / @types/command-line-args. * chore: Updated dependency version of ts-node * chore: Updated dependencies for component "typescript/npmconv". All dependencies that could be updated without too much effort were updated.

* chore: Ran npm update for vrotsc, updated package lock file. * chore: Updated "uuid" dependency for "vrotsc". * chore: Updated "js-yaml" dependency for "vrotsc". Also updated the "@types/js-yaml" definitions. * chore: Updated "minimist" dependency for "vrotsc". Also updated the "@types/minimist" definitions. * chore: Updated "xmlbuilder" dependency for "vrotsc". * chore: Updated "xmldoc" dependency for "vrotsc". Also updated the "@types/xmldoc" definitions. * chore: Updated "ansi-colors" dependency for "vrotsc". * chore: Updated "merge2" dependency for "vrotsc". * chore: Updated "rollup" dependency and plugins for "vrotsc". * chore: Updated "ts-node" dependency for "vrotsc". * chore: Updated gulp + sourcemap dependencies for "vrotsc".

Updated to latest versions of "which", "npm", "fs-extra" and "glob". Code changes related to supporting the latest library APIs.

…component "typescript/npmconv".

* chore: Updated Node.js and npm version requirements for "typescript/polyglotpkg" component. * chore: Updated dependencies for "typescript/polyglotpkg" component. Updated "which" / "@types/which" to latest, implemented code changes accordingly. * refactor: Removed "fs-extra" in favor of using Node.js API for "typescript/polyglotpkg" component. * refactor: Recursive copy exported to a filesystem utils class. Unit tests added for it. * refactor: Project build bootstrapping changed; replacing "globby" with capability in the project; updating dependencies" * chore: Removed "globby" as dependency. * refactor: Polyglot component not using globby and fs-extra libs any more. All dependencies updated to latest. Node.js 20 LTS support added. * refactor: Using native Node.js cpSync function.

…ot" component. (#7) * chore: Updated Node.js and npm version requirements for "typescript/polyglotpkg" component. * chore: Updated dependencies for "typescript/polyglotpkg" component. Updated "which" / "@types/which" to latest, implemented code changes accordingly. * refactor: Removed "fs-extra" in favor of using Node.js API for "typescript/polyglotpkg" component. * refactor: Recursive copy exported to a filesystem utils class. Unit tests added for it. * refactor: Project build bootstrapping changed; replacing "globby" with capability in the project; updating dependencies" * chore: Removed "globby" as dependency. * refactor: Polyglot component not using globby and fs-extra libs any more. All dependencies updated to latest. Node.js 20 LTS support added. * refactor: Using native Node.js cpSync function.

…ript/vro-scripting-api".

…ons' of https://github.com/pboychev-bcom/build-tools-for-vmware-aria into feature/463-update-dependencies-to-latest-package-versions

…test-package-versions

…onent now.

The following packages were updated to the latest versions available: - @rollup/plugin-commonjs - rollup - ts-node - typescript Signed-off-by: Plamen Boychev <[email protected]>

The following packages were updated to the latest versions available: - nyc - rimraf - ansi-colors - @types/ansi-colors - jszip - @types/jszip - @types/jasmine - jasmine - browserslist Signed-off-by: Plamen Boychev <[email protected]>

The following packages were updated to the latest versions available: - @types/minimist - minimist - source-map - @types/gulp Signed-off-by: Plamen Boychev <[email protected]>

Using the built-in "fs" Node.js module capabilities instead. Signed-off-by: Plamen Boychev <[email protected]>

Updates apply to npmconv, polyglotpkg and vropkg. Signed-off-by: Plamen Boychev <[email protected]>

Signed-off-by: Plamen Boychev <[email protected]>

…ckage-versions

vmwclabot · 2024-12-30T08:52:46Z

@deyan-r, you must sign every commit in this pull request acknowledging our Developer Certificate of Origin before your changes are merged. This can be done by adding Signed-off-by: John Doe <[email protected]> to the last line of each Git commit message. The e-mail address used to sign must match the e-mail address of the Git author. Click here to view the Developer Certificate of Origin agreement.

Commit fdc0d47 must be signed by [email protected]
Commit d06191f must be signed by [email protected]
Commit 494dc02 has a no-reply/unreachable author email address: [email protected]
Commit 8ba5b72 has a no-reply/unreachable author email address: [email protected]
Commit c4ebbef has a no-reply/unreachable author email address: [email protected]
Commit daf1ae5 must be signed by [email protected]
Commit b07d980 must be signed by [email protected]
Commit d13b372 must be signed by [email protected]
Commit 3fb1986 has a no-reply/unreachable author email address: [email protected]
Commit 04dba04 has a no-reply/unreachable author email address: [email protected]
Commit 7df4004 must be signed by [email protected]
Commit 130730c must be signed by [email protected]
Commit a4ca895 must be signed by [email protected]
Commit 19cf11f has a no-reply/unreachable author email address: [email protected]
Commit 665f7c2 must be signed by [email protected]
Commit 366008a must be signed by [email protected]
Commit 4696928 must be signed by [email protected]
Commit 41d3a60 must be signed by [email protected]
Commit a967248 must be signed by [email protected]
Commit 35c0863 must be signed by [email protected]
Commit 98bfe1f must be signed by [email protected]
Commit 3ecbd55 must be signed by [email protected]
Commit 5b79a31 must be signed by [email protected]
Commit 246f789 must be signed by [email protected]

vmwclabot · 2024-12-30T08:52:46Z

@deyan-r, you must sign every commit in this pull request acknowledging our Developer Certificate of Origin before your changes are merged. This can be done by adding Signed-off-by: John Doe <[email protected]> to the last line of each Git commit message. The e-mail address used to sign must match the e-mail address of the Git author. Click here to view the Developer Certificate of Origin agreement.

Commit fdc0d47 must be signed by [email protected]
Commit d06191f must be signed by [email protected]
Commit 494dc02 has a no-reply/unreachable author email address: [email protected]
Commit 8ba5b72 has a no-reply/unreachable author email address: [email protected]
Commit c4ebbef has a no-reply/unreachable author email address: [email protected]
Commit daf1ae5 must be signed by [email protected]
Commit b07d980 must be signed by [email protected]
Commit d13b372 must be signed by [email protected]
Commit 3fb1986 has a no-reply/unreachable author email address: [email protected]
Commit 04dba04 has a no-reply/unreachable author email address: [email protected]
Commit 7df4004 must be signed by [email protected]
Commit 130730c must be signed by [email protected]
Commit a4ca895 must be signed by [email protected]
Commit 19cf11f has a no-reply/unreachable author email address: [email protected]
Commit 665f7c2 must be signed by [email protected]
Commit 366008a must be signed by [email protected]
Commit 4696928 must be signed by [email protected]
Commit 41d3a60 must be signed by [email protected]
Commit a967248 must be signed by [email protected]
Commit 35c0863 must be signed by [email protected]
Commit 98bfe1f must be signed by [email protected]
Commit 3ecbd55 must be signed by [email protected]
Commit 5b79a31 must be signed by [email protected]
Commit 246f789 must be signed by [email protected]

VenelinBakalov · 2025-01-03T10:02:27Z

Nice that's quite some effort put in this one! I will try to get help with reviewing this PR soon. We will for sure need a Release.md entry with the changes you described in the PR description and also a suggested Upgrade procedure because of the major change of the node version. Let me first discuss internally how to handle that and then we can update the PR.

Michaelpalacce · 2025-01-07T10:51:46Z

@deyan-r great job on the PR, a lot of effort was put in it I can tell.

Michaelpalacce · 2025-01-07T10:52:42Z

Are there any obstacles to using nodejs22 instead of node 20? I would rather set that as the official goal as 20 is almost in maintenance.

ref: https://nodejs.org/en/about/previous-releases

Michaelpalacce · 2025-01-07T10:54:37Z

Checkout .github/workflows/build.yaml

        node: ["16.20.2"]
        node_vmware_samples: ["14.17.1"]

Should be changed to:

        node: ["22.12.0"]
        node_vmware_samples: ["22.12.0"]

Michaelpalacce · 2025-01-07T13:57:06Z

Generally we used tabs instead of spaces, I recommend you respect the editorconfig in the project so we don't have to see giant changelogs. It'd be great if you can fix this

Michaelpalacce · 2025-01-07T15:30:11Z

From all the de async-ing, I wonder if the speed was impacted negatively in any way

...archetypes/polyglot/src/main/resources/archetype-resources/src/template-nodejs/polyglot.json

Michaelpalacce · 2025-01-07T13:51:07Z

typescript/polyglotpkg/src/lib/file-system.ts

+    subPath?: string;
+    absolute?: boolean;
+}
+export function findFiles(patterns: RegExp[] | string[], options: FindFilesOptions = {}): string[] {


This is to replace globby I suppose? Can we add documentation here how to use this and we are good

Michaelpalacce · 2025-01-07T13:51:45Z

typescript/polyglotpkg/src/lib/file-system.ts

+ * This product may include a number of subcomponents with separate copyright notices and license terms. Your use of these subcomponents is subject to the terms and conditions of the subcomponent's license, as noted in the LICENSE file.
+ * #L%
+ */
+import { copyFileSync, mkdirSync, readdirSync, realpathSync, statSync } from "fs";


Unused imports

Michaelpalacce · 2025-01-07T15:13:54Z

typescript/vropkg/src/parse/util.ts

@@ -77,7 +77,7 @@ export const xmlToAction = (file: string, bundlePath: string, name: string, comm
 			};
 			params.push(param);
 		} else if (element.type == "element" && element.name == "script") {
-			inline = getScriptInline(file, element, comment, this.lazy);
+			inline = getScriptInline(file, element, comment, false); // @TODO: check if lazy parameter is still relevant 


It's not. Logic related to it can be removed

Michaelpalacce · 2025-01-07T15:15:19Z

typescript/vropkg/src/serialize/js.ts

@@ -17,6 +17,7 @@ import * as FileSystem from "fs-extra";
 import * as XmlBuilder from "xmlbuilder2";
 import * as unzipper from "unzipper";


Unused imports

Michaelpalacce · 2025-01-07T15:23:30Z

typescript/vropkg/src/serialize/tree.ts

    }
    xInfo.ele("entry").att("key", "categoryPath").text(pathKey)
-    if (element.type == t.VroElementType.ResourceElement) {
-        xInfo.ele("entry").att("key", "mimetype").text(element.attributes["mimetype"]);
+    if (element.type == t.VroElementType.ResourceElement && element.attributes["mimetype"]) {


In XML, an empty attribute (e.g., attribute="") is not the same as a missing attribute. An empty attribute explicitly indicates that the attribute exists but has no value, while a missing attribute indicates that the attribute does not exist at all. Not sure if this is important just wanted to note it

Will leave a //@note with this

Michaelpalacce · 2025-01-07T15:25:49Z

typescript/vropkg/tsconfig.json

+		"declaration": false,
+		"declarationMap": false,
+		"strict": false,
+    "newLine": "lf",


align a little bit

Michaelpalacce · 2025-01-07T15:28:18Z

typescript/vrotest/package.json

@@ -19,41 +19,35 @@
    "clean": "gulp clean"
  },
  "engines": {
-    "node": ">=16.15.1",
-    "npm": ">=6.14.0"
+    "node": ">=20.18.1",


Can we do an upper limit too?

Michaelpalacce · 2025-01-07T15:30:55Z

typescript/vrotest/src/util.ts

@@ -92,3 +92,15 @@ export async function withWorkingDir(dir: string, action: () => Promise<void>):
 		}
 	}
 }
+
+type CopyFilter = (fileName: string) => boolean;


Not used anywhere?

Michaelpalacce · 2025-01-08T12:36:58Z

Also, change the health.sh to be min/max Nodejs 22

MIN_NODE_VERSION="22"
MAX_NODE_VERSION="22"

pboychev-bcom and others added 30 commits November 7, 2024 16:26

chore: Updated dependencies to latest versions.

fdc0d47

Done for component docs/archive/doc. Tested with Node.js version 22.11.0.

chore: Updated dependencies to latest versions.

d06191f

Done for component typescript/vro-scripting-api. Tested with Node.js version 22.11.0.

update dependancies for typescript/vropkg

daf1ae5

chore: Updating dependencies for "typescript/npmconv" component.

b07d980

Updated to latest versions of "which", "npm", "fs-extra" and "glob". Code changes related to supporting the latest library APIs.

chore: Updated the minimum required versions for Node.js and npm for …

d13b372

…component "typescript/npmconv".

chore: Updated dependencies to latest available for component "typesc…

7df4004

…ript/vro-scripting-api".

updated vropkg dependencies

130730c

Merge branch 'feature/463-update-dependencies-to-latest-package-versi…

a4ca895

…ons' of https://github.com/pboychev-bcom/build-tools-for-vmware-aria into feature/463-update-dependencies-to-latest-package-versions

Merge branch 'vmware:main' into feature/463-update-dependencies-to-la…

19cf11f

…test-package-versions

update xmlbuilder and align code

665f7c2

updated fs-extra and unzipper and code fixes

366008a

style: Gulpfile is compliant with TS requirements in the vrotest comp…

4696928

…onent now.

chore(vrotsc): Updated dependencies.

d0de764

The following packages were updated to the latest versions available: - @rollup/plugin-commonjs - rollup - ts-node - typescript Signed-off-by: Plamen Boychev <[email protected]>

chore(vrotsc): Updated dependencies.

2b07fe8

The following packages were updated to the latest versions available: - nyc - rimraf - ansi-colors - @types/ansi-colors - jszip - @types/jszip - @types/jasmine - jasmine - browserslist Signed-off-by: Plamen Boychev <[email protected]>

chore(vrotsc): Updated dependencies.

4af1a0a

The following packages were updated to the latest versions available: - @types/minimist - minimist - source-map - @types/gulp Signed-off-by: Plamen Boychev <[email protected]>

chore(vrotsc): Removed "fs-extra" dependency.

51558ea

Using the built-in "fs" Node.js module capabilities instead. Signed-off-by: Plamen Boychev <[email protected]>

chore(typescript/*): Updated node types to latest available.

c3e5ce5

Updates apply to npmconv, polyglotpkg and vropkg. Signed-off-by: Plamen Boychev <[email protected]>

updated dependencies for typescript/npmconv

41d3a60

changes in vrotsc dependencies

a967248

chore(vrotest,vropkg,polyglotpkg,npmconv): Updating dependencies.

e925cbe

Signed-off-by: Plamen Boychev <[email protected]>

Merge branch 'main' into feature/463-update-dependencies-to-latest-pa…

35c0863

…ckage-versions

Merge branch 'main' into feature/463-update-dependencies-to-latest-pa…

98bfe1f

…ckage-versions

update minimatch for vrotsc

3ecbd55

synch dependencies of all components

5b79a31

update typescript version for vrotsc

246f789

update runtime for polyglot vro archetype sample project

d67edce

deyan-r requested a review from a team as a code owner December 30, 2024 08:52

vmwclabot added dco-required labels Dec 30, 2024

github-actions bot added kind/dependencies Pull requests that update a dependency file kind/feature New Feature to the project labels Dec 30, 2024

VenelinBakalov changed the title ~~Feature/463 update dependencies to latest package versions~~ [maven,typescript] (#463) Update dependencies to latest package versions Jan 3, 2025

VenelinBakalov changed the title ~~[maven,typescript] (#463) Update dependencies to latest package versions~~ [maven,typescript] (#332, #462, #463) Update dependencies to latest package versions Jan 3, 2025

Michaelpalacce requested changes Jan 7, 2025

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[maven,typescript] (#332, #462, #463) Update dependencies to latest package versions #582

[maven,typescript] (#332, #462, #463) Update dependencies to latest package versions #582

deyan-r commented Dec 30, 2024

vmwclabot commented Dec 30, 2024

vmwclabot commented Dec 30, 2024

VenelinBakalov commented Jan 3, 2025

Michaelpalacce commented Jan 7, 2025

Michaelpalacce commented Jan 7, 2025

Michaelpalacce commented Jan 7, 2025

Michaelpalacce commented Jan 7, 2025

Michaelpalacce commented Jan 7, 2025

Michaelpalacce Jan 7, 2025

Michaelpalacce Jan 7, 2025

Michaelpalacce Jan 7, 2025

Michaelpalacce Jan 7, 2025

Michaelpalacce Jan 7, 2025

Michaelpalacce Jan 8, 2025

Michaelpalacce Jan 7, 2025

Michaelpalacce Jan 7, 2025

Michaelpalacce Jan 7, 2025

Michaelpalacce commented Jan 8, 2025

		@@ -17,6 +17,7 @@ import * as FileSystem from "fs-extra";
		import * as XmlBuilder from "xmlbuilder2";
		import * as unzipper from "unzipper";

[maven,typescript] (#332, #462, #463) Update dependencies to latest package versions #582

Are you sure you want to change the base?

[maven,typescript] (#332, #462, #463) Update dependencies to latest package versions #582

Conversation

deyan-r commented Dec 30, 2024

Description

Checklist

Testing

Release Notes

Related issues and PRs

vmwclabot commented Dec 30, 2024

vmwclabot commented Dec 30, 2024

VenelinBakalov commented Jan 3, 2025

Michaelpalacce commented Jan 7, 2025

Michaelpalacce commented Jan 7, 2025

Michaelpalacce commented Jan 7, 2025

Michaelpalacce commented Jan 7, 2025

Michaelpalacce commented Jan 7, 2025

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Michaelpalacce commented Jan 8, 2025