Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reference same node types versions between different components #462

Open
pboychev-bcom opened this issue Oct 29, 2024 · 3 comments
Open
Assignees
Labels
area/dependencies Relates to updates to dependency file(s) effort/medium kind/enhancement Enhancement or improvement of existing features lang/javascript Releated to Javascript code lang/typescript Related to typescript code priority/medium triage/accepted The issue was accepted and will be done version/minor Introduces a non-breaking feature or change
Milestone

Comments

@pboychev-bcom
Copy link
Contributor

Description

Go through the different TypeScript components and check the Node types versions, update to latest, fix code as needed to support the updated versions.

@VenelinBakalov VenelinBakalov added kind/enhancement Enhancement or improvement of existing features area/dependencies Relates to updates to dependency file(s) lang/javascript Releated to Javascript code lang/typescript Related to typescript code triage/accepted The issue was accepted and will be done priority/medium effort/medium version/minor Introduces a non-breaking feature or change labels Oct 30, 2024
@pboychev-bcom
Copy link
Contributor Author

@Indy-rbo, sorry to bother you with this, I remember we discussed the topic in a meeting and since we're looking to start working on the implementation soon, I'd like to make sure we have the same understanding as yours on the matter, could you, please, share again here what the full requirements are /or as full as makes sense :)/, so we don't miss anything? Even if its an example comparison between two components.
Thanks in advance!

@Indy-rbo
Copy link
Contributor

@pboychev-bcom This topic is partly linked to #332. We have local tooling that received errors about some defintions because the node types in some places are of different versions (e.g. vropkg being on ^11.15.7 while vrotsc is on ^14.0.0).

We worked around this by adding in a step in some cases that basically performs npm i -D @types/node@^14.0.0 before our tooling runs but we prefer to not keep this workaround active.

So the requirement would be to have the version of @types/node match the latest (by BTVA supported) node version and have this consistent across the project (like vropkg and vrotsc).

@pboychev-bcom
Copy link
Contributor Author

Perfect, thanks, @Indy-rbo, exactly what we thought.
On it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/dependencies Relates to updates to dependency file(s) effort/medium kind/enhancement Enhancement or improvement of existing features lang/javascript Releated to Javascript code lang/typescript Related to typescript code priority/medium triage/accepted The issue was accepted and will be done version/minor Introduces a non-breaking feature or change
Projects
None yet
Development

No branches or pull requests

4 participants