Added modules to retrieve policy group and security policy objects #428
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I have been doing a lot of work with object data retrieved from NSX-T for objects relating to Distributed Firewall and it seems like a good idea to put them into the official ansible module. |
modified: plugins/module_utils/common_utils.py new file: plugins/modules/nsxt_policy_group_member_info.py new file: plugins/modules/nsxt_policy_group_member_types.py new file: plugins/modules/nsxt_policy_security_policy_facts.py new file: plugins/modules/nsxt_policy_security_policy_rule_stats.py new file: plugins/modules/nsxt_policy_security_policy_rules_facts.py
Added a number of modules relating to information about DFW policies and group objects: plugins/modules/nsxt_policy_domain_deployment_maps_info.py plugins/modules/nsxt_policy_domain_info.py plugins/modules/nsxt_policy_group_associations_info.py Modified the code in a number of modules to allow for local and global managers.
- plugins/modules/nsxt_policy_group_info.py - plugins/modules/nsxt_policy_group_member_info.py - plugins/modules/nsxt_policy_group_member_types.py - plugins/modules/nsxt_policy_security_policy_facts.py - plugins/modules/nsxt_policy_security_policy_rule_stats.py - plugins/modules/nsxt_policy_security_policy_rules_facts.py plugins/modules/common_utils.py modified. Functions used for building query strings in URIs and for handling retrieval of paged data were added. The collection as it is now does not implement modules for the retrieval of objects and focuses on CrUD ( no read ) functionality. I want to work to flesh out the "R" functionality. Signed-off-by: Ed McGuigan <[email protected]>
ParpingTam
force-pushed
the
add_facts_modules01
branch
from
afb15c3
to
b88099a
Compare
|
@ParpingTam, you must sign every commit in this pull request acknowledging our Developer Certificate of Origin before your changes are merged. This can be done by adding
|
|
I am also using some of your new modules. I found some documentation is wrong eg: nsxt_policy_group_member_info.py states module: nsxt_policy_group_members (_info is missing) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
plugins/modules/common_utils.py modified.
Functions used for building query strings in URIs and for handling
retrieval of paged data were added.
The collection as it is now does not implement modules for the
retrieval of objects and focuses on CrUD ( no read ) functionality.
I want to work to flesh out the "R" functionality.
Signed-off-by: Ed McGuigan [email protected]