Add support for diff and check mode for 3 modules
#394
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@hexmoose, you must sign every commit in this pull request acknowledging our Developer Certificate of Origin before your changes are merged. This can be done by adding
|
hexmoose
force-pushed
the
check-diff-mode-partial-support
branch
from
1f44ee8
to
ba0a69a
Compare
|
I've addressed the |
hexmoose
force-pushed
the
check-diff-mode-partial-support
branch
from
ba0a69a
to
acf633f
Compare
|
I've updated my commits to pull in the latest changes to |
added 2 commits
September 23, 2022 09:22
Add check mode change reporting to: - nsxt_policy_segment - nsxt_transport_zones - nsxt_uplink_profiles This will allow them to report `changed` only if the underlying resource has changed when using with `--check`. Related Issue: vmware#387 Signed-off-by: Jake <[email protected]>
Add diff mode change reporting to: - nsxt_policy_segment - nsxt_transport_zones - nsxt_uplink_profiles This will allow them to report diffs when using with `--diff`. This commit factors out the `check_for_update` function from `nsxt_base_resource.py` into `common_utils` and adds functionality so it can be used by multiple modules. Related Issue: vmware#387 Signed-off-by: Jake <[email protected]>
hexmoose
force-pushed
the
check-diff-mode-partial-support
branch
from
acf633f
to
60f5e1e
Compare
|
I've updated to include the latest changes on |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds support for
diffandcheckmodes for the following modules:This is an attempt to address #387 for the above modules.
Thanks for the review. I'll be happy to address any issues you find.