Only generate one Async Operation for CSI backup and some code refactor #231
+74
−87
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1. use function passed-in context. 2. replace the depracated apimachinery/pkg/util/wait method and variable. 3. remove unneeded function parameter. Signed-off-by: Xun Jiang <[email protected]>
blackpiglet
changed the title
blackpiglet
force-pushed
the
code_refactor
branch
2 times, most recently
from
53bca01
to
6cae6d1
Compare
reasonerjt
reviewed
Mar 21, 2024
Signed-off-by: Xun Jiang <[email protected]>
blackpiglet
force-pushed
the
code_refactor
branch
from
6cae6d1
to
96c47e7
Compare
There was a problem hiding this comment.
@blackpiglet Changes look good to me. But wanted to ask why the clubbing together of VS and VSC plugin operations ?
- Were there significant performance improvements observed at scale ?
- Or anything else like ease of ux/dev ?
The main consideration is not about the performance. The second factor is the main reason. There should be only one async operation for a volume backup. |
reasonerjt
approved these changes
Mar 22, 2024
shubham-pampattiwar
approved these changes
Mar 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
apimachinery/pkg/util/waitmethod and variable.