Add snapshot data mover logic in PVC RIA v2. #184
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
blackpiglet
changed the title
blackpiglet
force-pushed
the
6115_fix
branch
3 times, most recently
from
a1dead2
to
2e786a9
Compare
Lyndon-Li
reviewed
Jun 16, 2023
Lyndon-Li
reviewed
Jun 16, 2023
blackpiglet
force-pushed
the
6115_fix
branch
10 times, most recently
from
2e13023
to
39c6766
Compare
Lyndon-Li
previously approved these changes
Jun 21, 2023
Signed-off-by: Xun Jiang <[email protected]>
| // is not large enough. | ||
| // To counter that, here we set the storage request on the PVC to the larger of the PVC's storage request and the size of the | ||
| // VolumeSnapshot | ||
| setPVCStorageResourceRequest(pvc, restoreSize, logger) |
There was a problem hiding this comment.
+1 @blackpiglet
shubham-pampattiwar
approved these changes
Jun 21, 2023
Lyndon-Li
approved these changes
Jun 23, 2023
|
Also fix vmware-tanzu/velero#6116 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix vmware-tanzu/velero#6115