Fix the issue that NSX VPC not deleted when the Namespace is terminating #948
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #948 +/- ##
==========================================
- Coverage 73.43% 73.37% -0.06%
==========================================
Files 118 118
Lines 16414 16397 -17
==========================================
- Hits 12054 12032 -22
- Misses 3575 3581 +6
+ Partials 785 784 -1
|
wenyingd
force-pushed
the
bugfix_vpc_deletion
branch
2 times, most recently
from
67536db to
89fe570
Compare
|
/e2e |
2 similar comments
|
/e2e |
|
/e2e |
wenyingd
force-pushed
the
bugfix_vpc_deletion
branch
from
89fe570 to
b55a016
Compare
|
/e2e |
wenyingd
force-pushed
the
bugfix_vpc_deletion
branch
4 times, most recently
from
2a87f1d to
b71c919
Compare
|
/e2e |
wenyingd
force-pushed
the
bugfix_vpc_deletion
branch
3 times, most recently
from
c693177 to
7caf932
Compare
|
/e2e |
|
This change is intended to consider Namespaces in the terminating state when deleting stale VPCs, rather than |
wenyingd
changed the title
wenyingd
force-pushed
the
bugfix_vpc_deletion
branch
from
7caf932 to
ba216d7
Compare
Yes, updated the PR title. |
This change is to fix an issue with the NetworkInfo deletion logic that NSX VPC is not removed if the CR's Namesapce still exists. The fix is to add a wather on Namespace deletion event and ensure the NSX VPC is deleted when the K8s Namespace is deleted.
wenyingd
force-pushed
the
bugfix_vpc_deletion
branch
from
ba216d7 to
a04f5c4
Compare
lxiaopei
reviewed
Dec 13, 2024
lxiaopei
reviewed
Dec 13, 2024
lxiaopei
reviewed
Dec 13, 2024
timdengyun
reviewed
Dec 13, 2024
lxiaopei
reviewed
Dec 13, 2024
wenyingd
force-pushed
the
bugfix_vpc_deletion
branch
from
a04f5c4 to
52387a1
Compare
wenyingd
changed the title
wenyingd
added a commit
to wenyingd/nsx-operator
that referenced
this pull request
Dec 13, 2024
…ing (vmware-tanzu#948) * Fix issues with NetworkInfo reconciler that not delete NSX VPC in time This change is to fix an issue with the NetworkInfo deletion logic that NSX VPC is not removed if the CR's Namesapce still exists. The fix is to add a wather on Namespace deletion event and ensure the NSX VPC is deleted when the K8s Namespace is deleted. * Filter out the Namespace which is in terminating state
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change is to fix an issue with the NetworkInfo deletion logic that NSX VPC is not removed if the CR's Namesapce still exists.
The fix is to filter out the Namespace if it is already mark for deletion when a NetworkInfo CR is deleted.
Test Done:
With this fix, after the e2e is completed, the new created VPC by the test cases are deleted in time.