Remove staticroute finalizer #794
Open
+202
−83
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #794 +/- ##
==========================================
+ Coverage 49.05% 49.10% +0.05%
==========================================
Files 94 94
Lines 12194 12228 +34
==========================================
+ Hits 5982 6005 +23
- Misses 5709 5721 +12
+ Partials 503 502 -1
|
TaoZou1
force-pushed
the
removesrfinalizer
branch
3 times, most recently
from
e3f6489
to
3189009
Compare
|
/e2e |
timdengyun
reviewed
Oct 11, 2024
TaoZou1
force-pushed
the
removesrfinalizer
branch
from
3189009
to
b126df4
Compare
TaoZou1
force-pushed
the
removesrfinalizer
branch
from
b126df4
to
906a18c
Compare
wenqiq
reviewed
Oct 11, 2024
wenqiq
reviewed
Oct 11, 2024
wenqiq
reviewed
Oct 11, 2024
wenqiq
reviewed
Oct 11, 2024
wenqiq
reviewed
Oct 11, 2024
TaoZou1
force-pushed
the
removesrfinalizer
branch
from
906a18c
to
e37cb56
Compare
wenqiq
previously approved these changes
Oct 11, 2024
TaoZou1
force-pushed
the
removesrfinalizer
branch
from
e37cb56
to
34f5691
Compare
The finalizer may block the deletion since the NSX resource may take long time to delete. Remove the finalizer so the deleting operation will return immediately
TaoZou1
force-pushed
the
removesrfinalizer
branch
from
34f5691
to
8b58b87
Compare
|
/e2e |
wenqiq
approved these changes
Oct 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The finalizer may block the deletion since the NSX resource may take long time to delete.
Remove the finalizer so the deleting operation will return immediately
Test Done: