Add predicate func for pod controller and node controller #718
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zhengxiexie
force-pushed
the
zhengxie/node_filter_new
branch
from
5c994f0
to
251071e
Compare
|
|
timdengyun
reviewed
Oct 12, 2024
Yes, put it in predicate to avoid continuesly printing |
Update node predicate func, filter all the conditions compare. Add pod predicate func, remove host network check in the beginning of reconcile. Signed-off-by: Xie Zheng <[email protected]>
zhengxiexie
force-pushed
the
zhengxie/node_filter_new
branch
from
251071e
to
f7caed5
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #718 +/- ##
==========================================
+ Coverage 48.61% 48.99% +0.37%
==========================================
Files 94 94
Lines 12047 12210 +163
==========================================
+ Hits 5857 5982 +125
- Misses 5705 5725 +20
- Partials 485 503 +18
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update node predicate func, filter all the conditions, capacity and allocatable compare. Add pod predicate func, remove host network check in the beginning of reconcile.