-
Notifications
You must be signed in to change notification settings - Fork 362
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[velero] Refactoring labels and annotations #281
base: main
Are you sure you want to change the base?
Conversation
Signed-off-by: Nicolas Lamirault <[email protected]>
Signed-off-by: Nicolas Lamirault <[email protected]>
Signed-off-by: Nicolas Lamirault <[email protected]>
Signed-off-by: Nicolas Lamirault <[email protected]>
Signed-off-by: Nicolas Lamirault <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for your improvement to make the chart easier to read and configure.
But the CI is not passed, could you please take a look?
Signed-off-by: Nicolas Lamirault <[email protected]>
@jenting i don't understard CI error. Node not ready ? |
Okay, I'll look at it later. |
Signed-off-by: JenTing Hsiao <[email protected]>
I push a commit to test it :) |
{{- with .Values.labels }} | ||
{{- toYaml . | nindent 4 }} | ||
{{- end }} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
With removing these lines, will this make the labels duplicated?
{{- if .Values.customAnnotations }} | ||
{{- toYaml .Values.customAnnotations | nindent 4 }} | ||
{{- end }} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Personally, I'd prefer.
{{- With .Values.customAnnotations }}
{{- toYaml . | nindent 4 }}
{{- end }}
This makes the code simpler.
Signed-off-by: Nicolas Lamirault <[email protected]>
Signed-off-by: Nicolas Lamirault <[email protected]>
Signed-off-by: Nicolas Lamirault <[email protected]>
Signed-off-by: Nicolas Lamirault <[email protected]>
CI was failed, could you please take a look? Error: templates/: template: velero/templates/schedule.yaml:11:20: executing "velero/templates/schedule.yaml" at <.Values.customAnnotations>: nil pointer evaluating interface {}.customAnnotations |
Signed-off-by: Nicolas Lamirault <[email protected]>
Signed-off-by: Nicolas Lamirault <[email protected]>
Special notes for your reviewer:
name
label on 2 resourcesChecklist
[Place an '[x]' (no spaces) in all applicable fields. Please remove unrelated fields.]
[velero]
)