Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move from gcr to ghcr for the router and examples #1100

Merged
merged 1 commit into from
Sep 17, 2023
Merged

Move from gcr to ghcr for the router and examples #1100

merged 1 commit into from
Sep 17, 2023

Conversation

dolfolife
Copy link
Contributor

@dolfolife dolfolife commented Sep 11, 2023

Summary

The intent of these changes is to move the registry from GCR to GHCR.

TODO

  • Router
  • Examples
  • Update the veba.sbom file with the new urls

Change Type

What type of changes does your code introduce to the VMware Event Broker Appliance?

Put an x in all boxes that apply

Please check the types of change your PR introduces:

  • Bugfix (non-breaking change which fixes an issue)
  • Feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality not to work as expected)
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no API changes)
  • Build related changes
  • Documentation changes
  • Other (please describe): Image location

Additional Context

I do not have much context where most of the images are built. I took a look at the Github Action and found that the router is built there but none of the examples are. I am working on deleting the dependency of VEBA from GCR and moving to the GitHub registry since it is free for public repositories.

@vmwclabot
Copy link

@dolfolife, you must sign every commit in this pull request acknowledging our Developer Certificate of Origin before your changes are merged. This can be done by adding Signed-off-by: John Doe <[email protected]> to the last line of each Git commit message. The e-mail address used to sign must match the e-mail address of the Git author. Click here to view the Developer Certificate of Origin agreement.

@vmwclabot
Copy link

@dolfolife, you must sign every commit in this pull request acknowledging our Developer Certificate of Origin before your changes are merged. This can be done by adding Signed-off-by: John Doe <[email protected]> to the last line of each Git commit message. The e-mail address used to sign must match the e-mail address of the Git author. Click here to view the Developer Certificate of Origin agreement.

1 similar comment
@vmwclabot
Copy link

@dolfolife, you must sign every commit in this pull request acknowledging our Developer Certificate of Origin before your changes are merged. This can be done by adding Signed-off-by: John Doe <[email protected]> to the last line of each Git commit message. The e-mail address used to sign must match the e-mail address of the Git author. Click here to view the Developer Certificate of Origin agreement.

@dolfolife dolfolife marked this pull request as ready for review September 13, 2023 19:21
@dolfolife
Copy link
Contributor Author

@lamw I am ready to review these changes.

The main review would be to push all examples and the router using ghcr to this repository using the documentation I added in the PR.

Notes:

  • There was a FROM lamw/<repo> in one of the dockerfile on the example templates of a private repo that I deleted to make the build work.
  • Some of the python examples had a conflict on the requirements.txt that required a upgrade of a min version of a dependency.
  • I had to run go mod tidy in some of golang examples that made some changes.
  • There is still a case of images and labels with ghcr.io that when done manually it adds the image to the right repository but keeps it private. This step of making images public and maybe attach them to this repo might not work in all case scenarios.

@dolfolife dolfolife changed the title WIP: move from gcr to ghcr for the router Move from gcr to ghcr for the router and examples Sep 13, 2023
@lamw lamw requested a review from embano1 September 14, 2023 02:06
.github/workflows/release.yml Outdated Show resolved Hide resolved
.github/workflows/release.yml Outdated Show resolved Hide resolved
.github/workflows/release.yml Outdated Show resolved Hide resolved
.github/workflows/release.yml Outdated Show resolved Hide resolved
.github/workflows/release.yml Outdated Show resolved Hide resolved
.github/workflows/upload-dev-image.yml Outdated Show resolved Hide resolved
.github/workflows/upload-prerelease-image.yml Outdated Show resolved Hide resolved
examples/CONTRIBUTING.md Outdated Show resolved Hide resolved
examples/CONTRIBUTING.md Show resolved Hide resolved
vmware-event-router/.goreleaser.yaml Outdated Show resolved Hide resolved
@dolfolife
Copy link
Contributor Author

@embano1 made some changes. I hope I understood your change requests, but if I miss something please send me a message. Happy to continue reviewing this.

.github/workflows/release.yml Outdated Show resolved Hide resolved
.github/workflows/release.yml Outdated Show resolved Hide resolved
.github/workflows/release.yml Outdated Show resolved Hide resolved
.github/workflows/router-build.yml Outdated Show resolved Hide resolved
.github/workflows/upload-dev-image.yml Outdated Show resolved Hide resolved
.github/workflows/upload-prerelease-image.yml Outdated Show resolved Hide resolved
examples/CONTRIBUTING.md Show resolved Hide resolved
examples/CONTRIBUTING.md Outdated Show resolved Hide resolved
examples/CONTRIBUTING.md Outdated Show resolved Hide resolved
examples/CONTRIBUTING.md Outdated Show resolved Hide resolved
@embano1
Copy link
Collaborator

embano1 commented Sep 15, 2023

@embano1 made some changes. I hope I understood your change requests, but if I miss something please send me a message. Happy to continue reviewing this.

Yeah, mostly the Docker login stuff which can go away in all workflows since we're using ko defaults

.github/workflows/release.yml Outdated Show resolved Hide resolved
.github/workflows/release.yml Outdated Show resolved Hide resolved
.github/workflows/router-build.yml Outdated Show resolved Hide resolved
@embano1
Copy link
Collaborator

embano1 commented Sep 17, 2023

@dolfolife good job! Don't worry about the integration test (OpenFaaS): I'll fix later. Can you please squash your commits?

@embano1
Copy link
Collaborator

embano1 commented Sep 17, 2023

Is @lamw going to rebuild all images?

Copy link
Collaborator

@embano1 embano1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thx a ton @dolfolife

@embano1 embano1 merged commit d33774f into vmware-samples:development Sep 17, 2023
7 of 8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants