-
Notifications
You must be signed in to change notification settings - Fork 68
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move from gcr to ghcr for the router and examples #1100
Conversation
@dolfolife, you must sign every commit in this pull request acknowledging our Developer Certificate of Origin before your changes are merged. This can be done by adding
|
@dolfolife, you must sign every commit in this pull request acknowledging our Developer Certificate of Origin before your changes are merged. This can be done by adding
|
1 similar comment
@dolfolife, you must sign every commit in this pull request acknowledging our Developer Certificate of Origin before your changes are merged. This can be done by adding
|
@lamw I am ready to review these changes. The main review would be to push all examples and the router using ghcr to this repository using the documentation I added in the PR. Notes:
|
@embano1 made some changes. I hope I understood your change requests, but if I miss something please send me a message. Happy to continue reviewing this. |
Yeah, mostly the Docker login stuff which can go away in all workflows since we're using |
@dolfolife good job! Don't worry about the integration test (OpenFaaS): I'll fix later. Can you please squash your commits? |
Is @lamw going to rebuild all images? |
Signed-off-by: Rodolfo Sanchez <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thx a ton @dolfolife
Summary
The intent of these changes is to move the registry from GCR to GHCR.
TODO
veba.sbom
file with the new urlsChange Type
What type of changes does your code introduce to the VMware Event Broker Appliance?
Put an
x
in all boxes that applyPlease check the types of change your PR introduces:
Additional Context
I do not have much context where most of the images are built. I took a look at the Github Action and found that the router is built there but none of the examples are. I am working on deleting the dependency of VEBA from GCR and moving to the GitHub registry since it is free for public repositories.