feat: Integrate Tanzu Sources (vSphere/Horizon) for Knative #1075

lamw · 2023-06-27T17:28:40Z

Summary

This change refactors VEBA to now use Tanzu Sources for Knative when configuring either vSphere or Horizon sources and maintains event-router for Webhook processor configurations.

In addition, there were few optimizations that were needed including updating the VEBA VM hardware configuration which had some intermittent build errors preventing consistent builds.

Pull Request Checklist

🚨 Please review the guidelines for contributing to this repository.

Please ensure that you are making a pull request against the Development branch
Please use the WIP keyword in the title of your PR if you are not ready for review
Please ensure that you have opened a Github Issue if you are resolving/fixing a problem
Please ensure that you have signed all commits and that you have squashed all relevant commits related to your change
Please make sure that you have tested your change locally by successfully building and deploying the VMware Event Broker Appliance and/or building and deploying VMware Event Router
Please include any relevant screenshots and/or output as part of your testing
Please include any documentation updates that is applicable for your changes

Change Type

What types of changes does your code introduce to the VMware Event Broker Appliance?

Put an x in all boxes that apply

Please check the type of change your PR introduces:

Bugfix (non-breaking change which fixes an issue)
Feature (non-breaking change which adds functionality)
Breaking change (fix or feature that would cause existing functionality to not work as expected)
Code style update (formatting, renaming)
Refactoring (no functional changes, no api changes)
Build related changes
Documentation changes
Other (please describe):

Resolved Issues

Closes: #1066

Testing Verification

Successfully deployed VEBA appliance using various configurations including: vSphere, vSphere + Webhook, vSphere + Horizion + Webhook Processor

Additional Information

Any other details you wish to include or mention

If you have any questions/comments, feel free to reach out to team on Slack #vcenter-event-broker-appliance

Thank you from the VEBA Team! 🥳

embano1 · 2023-06-30T12:44:40Z

files/configs/horizon-source/templates/horizon-source-template.yml

+      name: default
+      namespace: vmware-functions
+  address: #@ "https://"+horizon
+  #@ if horizonTls == "True":


Just to double-check: if horizonTls == "True" means disable TLS or enable TLS? Current wording is confusing in conjunction with skipTLSVerify

That's correct, I most likely kept the variable name "simple" when working on vSphere sources from event-router, so just dup'ed variable name here but it is indeed reading from https://github.com/vmware-samples/vcenter-event-broker-appliance/blob/development/files/setup.sh#L34

Happy to modify for clarity purposes

Yeah, would be great to have those two align, i.e. if horizonTls == "True" skipTLSVerify should be false

embano1 · 2023-06-30T12:47:31Z

files/setup-06-vsphere-sources.sh

+echo -e "\e[92mCreating vSphere Secret ..." > /dev/console
+# Create vSphere Secret
+if [ ${VCENTER_DISABLE_TLS} == "True" ]; then
+    kn vsphere auth create \


Bit weird that you deploy most of it using YAML/ytt and here use a CLI. Why not use manifests?

I started out w/vSphere Sources which provided kn plugin ... I guess looking at Horizon Sources, I had no choice but perhaps might be good to just keep it consistent. I wasn't sure if there was a preference to leverage the plugin over manifests

Yeah, no benefit I guess in using the CLI, so let's go for consistency.

embano1 · 2023-06-30T12:49:08Z

files/setup-08-tinywww.sh

@@ -13,6 +13,11 @@ VEBA_CONFIG_FILE=/root/config/veba-config.json
 TINYWWW_TEMPLATE=/root/config/tinywww/templates/tinywww-template.yaml
 TINYWWW_CONFIG=/root/config/tinywww/tinywww.yaml

+# Basic Auth for TinyWWW endpoints
+kubectl -n vmware-system create secret generic basic-auth \


remind me, why and where is this needed now?

To access any of the endpoints served by TinyWWW - /events, /bootstrap, etc.

Basically, we don't want someone to be able to view events or debug logs w/o some sort of auth

ACK. And this is not handled by an Ingress? I thought we had those endpoints exposed through ingress which also has auth?

No, we've always had it like this

embano1 · 2023-06-30T12:50:43Z

files/setup-05-knative.sh

+if [ ${TANZU_SOURCES_DEBUG} -eq "True" ]; then
+    kubectl -n vmware-sources get cm config-logging -o yaml > /tmp/vmware-sources-config-logging.yaml
+    sed -i 's/"level": "info"/"level": "debug"/g' /tmp/vmware-sources-config-logging.yaml


Is this used/applied anyhwere? Not sure I'm understanding what this is supposed to do.

🦅 👁️ No, this was temp way of enabling debugging w/sources. Thanks to Gaberiel, this is now part of YTT setup for Sources

Let me remove

Haha, ok. 🦅 👁️ can still do it 🤣

Closes: 1066 Signed-off-by: William Lam <[email protected]>

embano1

LGTM

lamw added the enhancement New feature or request label Jun 27, 2023

lamw added this to the v0.8.0 milestone Jun 27, 2023

lamw requested a review from embano1 June 27, 2023 18:51

lamw changed the title ~~WIP feat: Integrate Tanzu Sources (vSphere/Horizon) for Knative~~ feat: Integrate Tanzu Sources (vSphere/Horizon) for Knative Jun 27, 2023

This was referenced Jun 27, 2023

Update VEBA UI plugin to use event types from Sources when creating trigger (filter) #908

Closed

Non-standard use of "subject" in CloudEvents Spec #182

Closed

[BUG] event router stops responding after a couple of days #1054

Closed

lamw force-pushed the issue-1066 branch from 359416a to f17eec5 Compare June 29, 2023 13:12

embano1 reviewed Jun 30, 2023

View reviewed changes

lamw force-pushed the issue-1066 branch 2 times, most recently from e3dc440 to 8aa1ca7 Compare July 9, 2023 14:40

feat: Integrate Tanzu Sources (vSphere/Horizon) for Knative

b4d6f40

Closes: 1066 Signed-off-by: William Lam <[email protected]>

lamw force-pushed the issue-1066 branch from 8aa1ca7 to b4d6f40 Compare July 9, 2023 17:29

lamw requested a review from embano1 July 9, 2023 17:29

embano1 approved these changes Jul 10, 2023

View reviewed changes

lamw merged commit 9ba9cdc into vmware-samples:development Jul 10, 2023
1 check passed

lamw deleted the issue-1066 branch July 10, 2023 15:28

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat: Integrate Tanzu Sources (vSphere/Horizon) for Knative #1075

feat: Integrate Tanzu Sources (vSphere/Horizon) for Knative #1075

lamw commented Jun 27, 2023

embano1 Jun 30, 2023 •

edited

Loading

lamw Jun 30, 2023

embano1 Jul 1, 2023

lamw Jul 9, 2023

embano1 Jun 30, 2023

lamw Jun 30, 2023

embano1 Jul 1, 2023

lamw Jul 9, 2023

embano1 Jun 30, 2023

lamw Jun 30, 2023

embano1 Jul 1, 2023

lamw Jul 9, 2023

embano1 Jun 30, 2023

lamw Jun 30, 2023

embano1 Jul 1, 2023

lamw Jul 9, 2023

embano1 left a comment

feat: Integrate Tanzu Sources (vSphere/Horizon) for Knative #1075

feat: Integrate Tanzu Sources (vSphere/Horizon) for Knative #1075

Conversation

lamw commented Jun 27, 2023

Summary

Pull Request Checklist

Change Type

Resolved Issues

Testing Verification

Additional Information

embano1 Jun 30, 2023 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

embano1 left a comment

Choose a reason for hiding this comment

embano1 Jun 30, 2023 •

edited

Loading